From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH 34/34] mm: dynamically allocate page->ptl if it cannot be embedded to struct page Date: Wed, 20 Nov 2013 15:06:26 +0200 (EET) Message-ID: <20131120130626.715B7E0090@blue.fi.intel.com> References: <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-35-git-send-email-kirill.shutemov@linux.intel.com> <20131120125325.07A42E0090@blue.fi.intel.com> Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Andrey Wagin Cc: "Kirill A. Shutemov" , Andrew Morton , Peter Zijlstra , Ingo Molnar , LKML , linux-mm@kvack.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org Andrey Wagin wrote: > 2013/11/20 Kirill A. Shutemov : > > Andrey Wagin wrote: > >> Hi Kirill, > >> > >> Looks like this patch adds memory leaks. > >> [ 116.188310] kmemleak: 15672 new suspected memory leaks (see > >> /sys/kernel/debug/kmemleak) > >> unreferenced object 0xffff8800da45a350 (size 96): > >> comm "dracut-initqueu", pid 93, jiffies 4294671391 (age 362.277s) > >> hex dump (first 32 bytes): > >> 07 00 07 00 ad 4e ad de ff ff ff ff 6b 6b 6b 6b .....N......kkkk > >> ff ff ff ff ff ff ff ff 80 24 b4 82 ff ff ff ff .........$...... > >> backtrace: > >> [] kmemleak_alloc+0x5e/0xc0 > >> [] kmem_cache_alloc_trace+0x113/0x290 > >> [] __ptlock_alloc+0x27/0x50 > >> [] __pmd_alloc+0x59/0x170 > >> [] copy_page_range+0x38a/0x3e0 > >> [] dup_mm+0x313/0x540 > >> [] copy_process+0x161a/0x1880 > >> [] do_fork+0x8b/0x360 > >> [] SyS_clone+0x16/0x20 > >> [] stub_clone+0x69/0x90 > >> [] 0xffffffffffffffff > >> > >> It's quite serious, because my test host went to panic in a few hours. > > > > Sorry for that. > > > > Could you test patch below. > > Yes, it works. > > I found this too a few minutes ago:) Nice Tested-by ? -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:8507 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495Ab3KTNGc (ORCPT ); Wed, 20 Nov 2013 08:06:32 -0500 From: "Kirill A. Shutemov" In-Reply-To: References: <1381428359-14843-1-git-send-email-kirill.shutemov@linux.intel.com> <1381428359-14843-35-git-send-email-kirill.shutemov@linux.intel.com> <20131120125325.07A42E0090@blue.fi.intel.com> Subject: Re: [PATCH 34/34] mm: dynamically allocate page->ptl if it cannot be embedded to struct page Content-Transfer-Encoding: 7bit Message-ID: <20131120130626.715B7E0090@blue.fi.intel.com> Date: Wed, 20 Nov 2013 15:06:26 +0200 (EET) Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrey Wagin Cc: "Kirill A. Shutemov" , Andrew Morton , Peter Zijlstra , Ingo Molnar , LKML , linux-mm@kvack.org, linux-arch@vger.kernel.org Message-ID: <20131120130626._ZDNz3gIwUxa6Z6tw7nUqa3zunSN8RMRRHidoE9Q7Z4@z> Andrey Wagin wrote: > 2013/11/20 Kirill A. Shutemov : > > Andrey Wagin wrote: > >> Hi Kirill, > >> > >> Looks like this patch adds memory leaks. > >> [ 116.188310] kmemleak: 15672 new suspected memory leaks (see > >> /sys/kernel/debug/kmemleak) > >> unreferenced object 0xffff8800da45a350 (size 96): > >> comm "dracut-initqueu", pid 93, jiffies 4294671391 (age 362.277s) > >> hex dump (first 32 bytes): > >> 07 00 07 00 ad 4e ad de ff ff ff ff 6b 6b 6b 6b .....N......kkkk > >> ff ff ff ff ff ff ff ff 80 24 b4 82 ff ff ff ff .........$...... > >> backtrace: > >> [] kmemleak_alloc+0x5e/0xc0 > >> [] kmem_cache_alloc_trace+0x113/0x290 > >> [] __ptlock_alloc+0x27/0x50 > >> [] __pmd_alloc+0x59/0x170 > >> [] copy_page_range+0x38a/0x3e0 > >> [] dup_mm+0x313/0x540 > >> [] copy_process+0x161a/0x1880 > >> [] do_fork+0x8b/0x360 > >> [] SyS_clone+0x16/0x20 > >> [] stub_clone+0x69/0x90 > >> [] 0xffffffffffffffff > >> > >> It's quite serious, because my test host went to panic in a few hours. > > > > Sorry for that. > > > > Could you test patch below. > > Yes, it works. > > I found this too a few minutes ago:) Nice Tested-by ? -- Kirill A. Shutemov