From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist Date: Wed, 20 Nov 2013 16:38:01 +0100 Message-ID: <20131120153801.GA9743@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Frank Ch. Eigler" Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, systemtap@sourceware.org, Masami Hiramatsu , "David S. Miller" List-Id: linux-arch.vger.kernel.org * Frank Ch. Eigler wrote: > masami.hiramatsu.pt wrote: > > > [...] This series also includes a change which prohibits probing > > on the address in .entry.text because the code is used for very > > low-level sensitive interrupt/syscall entries. Probing such code > > may cause unexpected result (actually most of that area is already > > in the kprobe blacklist). So I've decide to prohibit probing all > > of them. [...] > > Does this new blacklist cover enough that the kernel now survives a > broadly wildcarded perf-probe, e.g. over e.g. all of its kallsyms? That's generally the purpose of the annotations - if it doesn't then that's a bug. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f51.google.com ([209.85.214.51]:40722 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060Ab3KTPiG (ORCPT ); Wed, 20 Nov 2013 10:38:06 -0500 Date: Wed, 20 Nov 2013 16:38:01 +0100 From: Ingo Molnar Subject: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist Message-ID: <20131120153801.GA9743@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Frank Ch. Eigler" Cc: Masami Hiramatsu , linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, systemtap@sourceware.org, "David S. Miller" Message-ID: <20131120153801.F_aqZkcxGwLtvBijlsPtZg8yEaWIXtC2WpL2arTMT-s@z> * Frank Ch. Eigler wrote: > masami.hiramatsu.pt wrote: > > > [...] This series also includes a change which prohibits probing > > on the address in .entry.text because the code is used for very > > low-level sensitive interrupt/syscall entries. Probing such code > > may cause unexpected result (actually most of that area is already > > in the kprobe blacklist). So I've decide to prohibit probing all > > of them. [...] > > Does this new blacklist cover enough that the kernel now survives a > broadly wildcarded perf-probe, e.g. over e.g. all of its kallsyms? That's generally the purpose of the annotations - if it doesn't then that's a bug. Thanks, Ingo