From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH -tip v3 18/23] x86/dumpstack: Use NOKPROBE_SYMBOL macro in dumpstack.c Date: Thu, 21 Nov 2013 12:30:06 +0100 Message-ID: <20131121113006.GA27659@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120042233.15296.31189.stgit@kbuild-fedora.novalocal> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131120042233.15296.31189.stgit@kbuild-fedora.novalocal> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , "David S. Miller" , Sandeepa Prabhu , Vineet Gupta , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, Ingo Molnar , systemtap@sourceware.org, "H. Peter Anvin" , Tejun Heo , Andrew Morton , Jiri Slaby , Thomas Gleixner List-Id: linux-arch.vger.kernel.org * Masami Hiramatsu wrote: > Use NOKPROBE_SYMBOL macro for protecting functions > from kprobes instead of __kprobes annotation in > dumpstack.c. > > Signed-off-by: Masami Hiramatsu > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Andrew Morton > Cc: Jiri Slaby > Cc: Tejun Heo > Cc: Vineet Gupta > --- > arch/x86/kernel/dumpstack.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Btw., all these mechanic changes of the __kprobes annotation can be merged into a single patch. That will cut down on the size of the series substantially. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f42.google.com ([209.85.214.42]:41587 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754494Ab3KULaK (ORCPT ); Thu, 21 Nov 2013 06:30:10 -0500 Date: Thu, 21 Nov 2013 12:30:06 +0100 From: Ingo Molnar Subject: Re: [PATCH -tip v3 18/23] x86/dumpstack: Use NOKPROBE_SYMBOL macro in dumpstack.c Message-ID: <20131121113006.GA27659@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120042233.15296.31189.stgit@kbuild-fedora.novalocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131120042233.15296.31189.stgit@kbuild-fedora.novalocal> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , Vineet Gupta , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, Andrew Morton , Ingo Molnar , systemtap@sourceware.org, "H. Peter Anvin" , Tejun Heo , Thomas Gleixner , Jiri Slaby , "David S. Miller" Message-ID: <20131121113006.OmHsaC8CpvFClpQ04e1UApG3_CNeQFPzDPbJq8xS61k@z> * Masami Hiramatsu wrote: > Use NOKPROBE_SYMBOL macro for protecting functions > from kprobes instead of __kprobes annotation in > dumpstack.c. > > Signed-off-by: Masami Hiramatsu > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Andrew Morton > Cc: Jiri Slaby > Cc: Tejun Heo > Cc: Vineet Gupta > --- > arch/x86/kernel/dumpstack.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Btw., all these mechanic changes of the __kprobes annotation can be merged into a single patch. That will cut down on the size of the series substantially. Thanks, Ingo