From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH v6 4/5] MCS Lock: Barrier corrections Date: Mon, 25 Nov 2013 09:56:16 -0800 Message-ID: <20131125175616.GQ4138@linux.vnet.ibm.com> References: <20131122215208.GD4138@linux.vnet.ibm.com> <20131123002542.GF4138@linux.vnet.ibm.com> <20131123013654.GG4138@linux.vnet.ibm.com> <20131125120902.GY10022@twins.programming.kicks-ass.net> <20131125171823.GA28201@mudshark.cambridge.arm.com> Reply-To: paulmck@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131125171823.GA28201@mudshark.cambridge.arm.com> Sender: owner-linux-mm@kvack.org To: Will Deacon Cc: Peter Zijlstra , Linus Torvalds , Ingo Molnar , Tim Chen , Ingo Molnar , Andrew Morton , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-mm , "linux-arch@vger.kernel.org" , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel Peter Hurley List-Id: linux-arch.vger.kernel.org On Mon, Nov 25, 2013 at 05:18:23PM +0000, Will Deacon wrote: > Hi Peter, Linus, > > On Mon, Nov 25, 2013 at 12:09:02PM +0000, Peter Zijlstra wrote: > > On Sat, Nov 23, 2013 at 12:39:53PM -0800, Linus Torvalds wrote: > > > On Sat, Nov 23, 2013 at 12:21 PM, Linus Torvalds > > > wrote: > > > > > > > > And as far as I can tell, the above gives you: A < B < C < D < E < F < > > > > A. Which doesn't look possible. > > > > > > Hmm.. I guess technically all of those cases aren't "strictly > > > precedes" as much as "cannot have happened in the opposite order". So > > > the "<" might be "<=". Which I guess *is* possible: "it all happened > > > at the same time". And then the difference between your suggested > > > "lwsync" and "sync" in the unlock path on CPU0 basically approximating > > > the difference between "A <= B" and "A < B".. > > > > > > Ho humm. > > > > But remember, there's an actual full proper barrier between E and F, so > > at best you'd end up with something like: > > > > A <= B <= C <= D <= E < F <= A > > > > Which is still an impossibility. > > > > I'm hoping others will explain things, as I'm very much on shaky ground > > myself wrt transitivity. > > The transitivity issues come about by having multiple, valid copies of the > same data at a given moment in time (hence the term `multi-copy atomicity', > where all of these copies appear to be updated at once). > > Now, I'm not familiar with the Power memory model and the implementation > intricacies between lwsync and sync, but I think a better way to think > about this is to think of the cacheline state changes being broadcast as > asynchronous requests, rather than necessarily responding to snoops from a > canonical source. > > So, in Paul's example, the upgrade requests on X and lock (shared -> invalid) > may have reached CPU1, but not CPU2 by the time CPU2 reads X and therefore > reads 0 from its shared line. It really depends on the multi-copy semantics > you give to the different barrier instructions. Exactly! ;-) > The other thing worth noting is that exclusive access instructions (e.g. > ldrex and strex on ARM) may interact differently with barriers than conventional > accesses, so lighter weight barriers can sometimes be acceptable for things > like locks and atomics. > > Does that help at all? The differences between ldrex/strex and larx/stcx cannot come into play in this example because there are only normal loads and stores, no atomic instructions. Thanx, Paul > Will > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org