From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH -tip v3 02/23] kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist Date: Wed, 27 Nov 2013 14:32:24 +0100 Message-ID: <20131127133224.GD18422@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120042153.15296.82087.stgit@kbuild-fedora.novalocal> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131120042153.15296.82087.stgit@kbuild-fedora.novalocal> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Jeremy Fitzhardinge , x86@kernel.org, Ananth N Mavinakayanahalli , Arnd Bergmann , "David S. Miller" , Sandeepa Prabhu , lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, Chris Wright , Peter Zijlstra , Ingo Molnar , Rob Landley , "H. Peter Anvin" , Thomas Gleixner , Alok Kataria , systemtap@sourceware.org List-Id: linux-arch.vger.kernel.org * Masami Hiramatsu wrote: > +#ifdef CONFIG_KPROBES > +/* > + * Blacklist ganerating macro. Specify functions which is not probed > + * by using this macro. > + */ > +#define __NOKPROBE_SYMBOL(fname) \ > +static struct kprobe_blackpoint __used \ > + _kprobe_bp_##fname = { \ > + .name = #fname, \ > + .start_addr = (unsigned long)fname, \ > + }; \ > +static struct kprobe_blackpoint __used \ > + __attribute__((section("_kprobe_blacklist"))) \ > + *_p_kprobe_bp_##fname = &_kprobe_bp_##fname; 'kprobe_blackpoint' sounds a bit weird - how about 'kprobe_blacklist_entry' ? also, _kprobe_blacklist probably wants to be _kprobes_blacklist, right? Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f45.google.com ([209.85.214.45]:34315 "EHLO mail-bk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986Ab3K0Nc2 (ORCPT ); Wed, 27 Nov 2013 08:32:28 -0500 Date: Wed, 27 Nov 2013 14:32:24 +0100 From: Ingo Molnar Subject: Re: [PATCH -tip v3 02/23] kprobes: Introduce NOKPROBE_SYMBOL() macro for blacklist Message-ID: <20131127133224.GD18422@gmail.com> References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120042153.15296.82087.stgit@kbuild-fedora.novalocal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131120042153.15296.82087.stgit@kbuild-fedora.novalocal> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Jeremy Fitzhardinge , Rusty Russell , Ananth N Mavinakayanahalli , Arnd Bergmann , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, Chris Wright , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Rob Landley , systemtap@sourceware.org, "H. Peter Anvin" , Alok Kataria , "David S. Miller" Message-ID: <20131127133224.kEY8SBgKOdZTDtCdSoDPKk0dZMD-sK-I7sxp-RX44oc@z> * Masami Hiramatsu wrote: > +#ifdef CONFIG_KPROBES > +/* > + * Blacklist ganerating macro. Specify functions which is not probed > + * by using this macro. > + */ > +#define __NOKPROBE_SYMBOL(fname) \ > +static struct kprobe_blackpoint __used \ > + _kprobe_bp_##fname = { \ > + .name = #fname, \ > + .start_addr = (unsigned long)fname, \ > + }; \ > +static struct kprobe_blackpoint __used \ > + __attribute__((section("_kprobe_blacklist"))) \ > + *_p_kprobe_bp_##fname = &_kprobe_bp_##fname; 'kprobe_blackpoint' sounds a bit weird - how about 'kprobe_blacklist_entry' ? also, _kprobe_blacklist probably wants to be _kprobes_blacklist, right? Thanks, Ingo