From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v8 4/6] MCS Lock: Move mcs_lock/unlock function into its own Date: Tue, 21 Jan 2014 11:19:15 +0100 Message-ID: <20140121101915.GS31570@twins.programming.kicks-ass.net> References: <1390267471.3138.38.camel@schen9-DESK> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1390267471.3138.38.camel@schen9-DESK> Sender: owner-linux-mm@kvack.org To: Tim Chen Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin List-Id: linux-arch.vger.kernel.org On Mon, Jan 20, 2014 at 05:24:31PM -0800, Tim Chen wrote: > +EXPORT_SYMBOL_GPL(mcs_spin_lock); > +EXPORT_SYMBOL_GPL(mcs_spin_unlock); Do we really need the EXPORTs? The only user so far is mutex and that's core code. The other planned users are rwsems and rwlocks, for both it would be in the slow path, which is also core code. We should generally only add EXPORTs once theres a need. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org ([205.233.59.134]:48959 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754042AbaAUKTs (ORCPT ); Tue, 21 Jan 2014 05:19:48 -0500 Date: Tue, 21 Jan 2014 11:19:15 +0100 From: Peter Zijlstra Subject: Re: [PATCH v8 4/6] MCS Lock: Move mcs_lock/unlock function into its own Message-ID: <20140121101915.GS31570@twins.programming.kicks-ass.net> References: <1390267471.3138.38.camel@schen9-DESK> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1390267471.3138.38.camel@schen9-DESK> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Tim Chen Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , "Paul E.McKenney" , Will Deacon , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin Chandramouleeswaran , Scott J Norton , "Figo.zhang" Message-ID: <20140121101915.fhkinfA6ca3b4qIng2MSJhxKCfIcCT7VOAGgk-edTzU@z> On Mon, Jan 20, 2014 at 05:24:31PM -0800, Tim Chen wrote: > +EXPORT_SYMBOL_GPL(mcs_spin_lock); > +EXPORT_SYMBOL_GPL(mcs_spin_unlock); Do we really need the EXPORTs? The only user so far is mutex and that's core code. The other planned users are rwsems and rwlocks, for both it would be in the slow path, which is also core code. We should generally only add EXPORTs once theres a need.