linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Waiman Long <waiman.long@hp.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michel Lespinasse <walken@google.com>,
	Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	George Spelvin <linux@horizon.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Daniel J Blueman <daniel@numascale.com>,
	Alexander Fyodorov <halcy@yandex.ru>,
	Aswin Chandramouleeswaran <aswin@hp.com>,
	Scott J Norton <scott.norton@hp.com>,
	Thavatchai Makphaibulchoke <thavatchai.makpahibulchoke@hp.com>
Subject: Re: [PATCH v3 1/2] qspinlock: Introducing a 4-byte queue spinlock implementation
Date: Fri, 7 Feb 2014 10:17:37 -0800	[thread overview]
Message-ID: <20140207181737.GS4250@linux.vnet.ibm.com> (raw)
In-Reply-To: <52F2FD2A.1020704@hp.com>

On Wed, Feb 05, 2014 at 10:10:34PM -0500, Waiman Long wrote:
> On 02/03/2014 06:40 AM, Peter Zijlstra wrote:
> >On Fri, Jan 31, 2014 at 02:24:33PM -0500, Waiman Long wrote:
> >>Light contention is the only case where the qspinlock may not perform as
> >>good as the ticket spinlock. I know this is the most common case. However, I
> >>would argue that the slowdown, if any, will not be really noticeable. This
> >>is what I will try to find out.
> >Please also explain why things are slower/faster. Thomas tried to get
> >you to do so a few months back, but you kept deflecting.
> 
> It is not easy to have a test case to test light contention. I am
> trying to create custom test case to get that data.

Here are some ways of doing that:

1.	Provide (say) a thousand locks for each thread, so that you
	have all of these locks in one big array of locks.  Have each
	thread loop, where each pass through the loop acquires
	and releases a randomly selected lock.	Then measure the
	acquisition/release throughput.

2.	As #1 above, but vary the number of locks per thread in order to
	vary the level of contention in a controlled manner.  Note that
	the cache-miss probability is (N-1)/N, where where N is the
	number of threads, at least assuming each thread gets its own CPU.

3.	Provide each thread with its own lock and have each thread
	loop, where each pass through the loop acquires and releases
	the thread's lock.  This eliminates both contention and
	cache misses.

4.	As #1 above, but randomly acquire some other thread's lock with
	controlled probability to introduce controlled levels of both
	contention and cache misses.

5.	As #4 above, but provide each thread with multiple locks
	randomly selected to allow cache miss rate to be increased
	independently of contention.

All approaches require extremely efficient random-number generators,
for example, independent per-thread generators.

							Thanx, Paul

  reply	other threads:[~2014-02-07 18:17 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 18:19 [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock Waiman Long
2014-01-28 18:19 ` [PATCH v3 1/2] qspinlock: Introducing a 4-byte queue spinlock implementation Waiman Long
2014-01-28 18:19   ` Waiman Long
2014-01-29  0:20   ` Andi Kleen
2014-01-29  0:20     ` Andi Kleen
2014-01-29  2:57     ` George Spelvin
2014-01-29 17:57     ` Waiman Long
2014-01-29 17:57       ` Waiman Long
2014-01-30 17:43   ` Rik van Riel
2014-01-30 19:00   ` Tim Chen
2014-01-30 19:28     ` Peter Zijlstra
2014-01-30 22:27       ` Tim Chen
2014-01-31 18:26       ` Waiman Long
2014-01-31 18:26         ` Waiman Long
2014-01-31 19:14         ` George Spelvin
2014-01-31 19:28           ` Waiman Long
2014-01-31 19:45         ` Peter Zijlstra
2014-01-31 18:16     ` Waiman Long
2014-01-30 19:35   ` Peter Zijlstra
2014-01-31 18:28     ` Waiman Long
2014-01-31 15:08   ` Peter Zijlstra
2014-01-31 19:24     ` Waiman Long
2014-01-31 19:24       ` Waiman Long
2014-01-31 19:51       ` Peter Zijlstra
2014-02-03 11:40       ` Peter Zijlstra
2014-02-06  3:10         ` Waiman Long
2014-02-07 18:17           ` Paul E. McKenney [this message]
2014-02-03  8:51   ` Raghavendra K T
2014-01-28 18:19 ` [PATCH v3 2/2] qspinlock, x86: Enable x86-64 to use queue spinlock Waiman Long
2014-01-30 17:45   ` Rik van Riel
2014-01-30  8:55 ` [PATCH v3 0/2] qspinlock: Introducing a 4-byte " Raghavendra K T
2014-01-30 15:38   ` Waiman Long
2014-01-30 15:38     ` Waiman Long
2014-01-30 18:49     ` Raghavendra K T
2014-02-03  8:51       ` Raghavendra K T
2014-02-03  8:51         ` Raghavendra K T
2014-02-06  3:09         ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207181737.GS4250@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arnd@arndb.de \
    --cc=aswin@hp.com \
    --cc=daniel@numascale.com \
    --cc=halcy@yandex.ru \
    --cc=hpa@zytor.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=riel@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=scott.norton@hp.com \
    --cc=tglx@linutronix.de \
    --cc=thavatchai.makpahibulchoke@hp.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=waiman.long@hp.com \
    --cc=walken@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).