From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> To: paulus@samba.org, oleg@redhat.com, rusty@rustcorp.com.au, peterz@infradead.org, tglx@linutronix.de, akpm@linux-foundation.org Cc: paulmck@linux.vnet.ibm.com, tj@kernel.org, walken@google.com, ego@linux.vnet.ibm.com, linux@arm.linux.org.uk, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com, Ingo Molnar <mingo@kernel.org>"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> Subject: [PATCH v2 01/52] CPU hotplug: Add lockdep annotations to get/put_online_cpus() Date: Fri, 14 Feb 2014 13:19:14 +0530 [thread overview] Message-ID: <20140214074913.22701.44704.stgit@srivatsabhat.in.ibm.com> (raw) In-Reply-To: <20140214074750.22701.47330.stgit@srivatsabhat.in.ibm.com> From: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Add lockdep annotations for get/put_online_cpus() and cpu_hotplug_begin()/cpu_hotplug_end(). Cc: Ingo Molnar <mingo@kernel.org> Reviewed-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- kernel/cpu.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/kernel/cpu.c b/kernel/cpu.c index deff2e6..33caf5e 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -19,6 +19,7 @@ #include <linux/mutex.h> #include <linux/gfp.h> #include <linux/suspend.h> +#include <linux/lockdep.h> #include "smpboot.h" @@ -57,17 +58,30 @@ static struct { * an ongoing cpu hotplug operation. */ int refcount; + +#ifdef CONFIG_DEBUG_LOCK_ALLOC + struct lockdep_map dep_map; +#endif } cpu_hotplug = { .active_writer = NULL, .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), .refcount = 0, +#ifdef CONFIG_DEBUG_LOCK_ALLOC + .dep_map = {.name = "cpu_hotplug.lock" }, +#endif }; +/* Lockdep annotations for get/put_online_cpus() and cpu_hotplug_begin/end() */ +#define cpuhp_lock_acquire_read() lock_map_acquire_read(&cpu_hotplug.dep_map) +#define cpuhp_lock_acquire() lock_map_acquire(&cpu_hotplug.dep_map) +#define cpuhp_lock_release() lock_map_release(&cpu_hotplug.dep_map) + void get_online_cpus(void) { might_sleep(); if (cpu_hotplug.active_writer == current) return; + cpuhp_lock_acquire_read(); mutex_lock(&cpu_hotplug.lock); cpu_hotplug.refcount++; mutex_unlock(&cpu_hotplug.lock); @@ -87,6 +101,7 @@ void put_online_cpus(void) if (!--cpu_hotplug.refcount && unlikely(cpu_hotplug.active_writer)) wake_up_process(cpu_hotplug.active_writer); mutex_unlock(&cpu_hotplug.lock); + cpuhp_lock_release(); } EXPORT_SYMBOL_GPL(put_online_cpus); @@ -117,6 +132,7 @@ void cpu_hotplug_begin(void) { cpu_hotplug.active_writer = current; + cpuhp_lock_acquire(); for (;;) { mutex_lock(&cpu_hotplug.lock); if (likely(!cpu_hotplug.refcount)) @@ -131,6 +147,7 @@ void cpu_hotplug_done(void) { cpu_hotplug.active_writer = NULL; mutex_unlock(&cpu_hotplug.lock); + cpuhp_lock_release(); } /*
WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> To: paulus@samba.org, oleg@redhat.com, mingo@kernel.org, rusty@rustcorp.com.au, peterz@infradead.org, tglx@linutronix.de, akpm@linux-foundation.org Cc: paulmck@linux.vnet.ibm.com, tj@kernel.org, walken@google.com, ego@linux.vnet.ibm.com, linux@arm.linux.org.uk, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> Subject: [PATCH v2 01/52] CPU hotplug: Add lockdep annotations to get/put_online_cpus() Date: Fri, 14 Feb 2014 13:19:14 +0530 [thread overview] Message-ID: <20140214074913.22701.44704.stgit@srivatsabhat.in.ibm.com> (raw) Message-ID: <20140214074914.DR7nkvd9N6I0av39VUs9nyBCg8DdpuBoJcQPfNW43kI@z> (raw) In-Reply-To: <20140214074750.22701.47330.stgit@srivatsabhat.in.ibm.com> From: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Add lockdep annotations for get/put_online_cpus() and cpu_hotplug_begin()/cpu_hotplug_end(). Cc: Ingo Molnar <mingo@kernel.org> Reviewed-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- kernel/cpu.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/kernel/cpu.c b/kernel/cpu.c index deff2e6..33caf5e 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -19,6 +19,7 @@ #include <linux/mutex.h> #include <linux/gfp.h> #include <linux/suspend.h> +#include <linux/lockdep.h> #include "smpboot.h" @@ -57,17 +58,30 @@ static struct { * an ongoing cpu hotplug operation. */ int refcount; + +#ifdef CONFIG_DEBUG_LOCK_ALLOC + struct lockdep_map dep_map; +#endif } cpu_hotplug = { .active_writer = NULL, .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), .refcount = 0, +#ifdef CONFIG_DEBUG_LOCK_ALLOC + .dep_map = {.name = "cpu_hotplug.lock" }, +#endif }; +/* Lockdep annotations for get/put_online_cpus() and cpu_hotplug_begin/end() */ +#define cpuhp_lock_acquire_read() lock_map_acquire_read(&cpu_hotplug.dep_map) +#define cpuhp_lock_acquire() lock_map_acquire(&cpu_hotplug.dep_map) +#define cpuhp_lock_release() lock_map_release(&cpu_hotplug.dep_map) + void get_online_cpus(void) { might_sleep(); if (cpu_hotplug.active_writer == current) return; + cpuhp_lock_acquire_read(); mutex_lock(&cpu_hotplug.lock); cpu_hotplug.refcount++; mutex_unlock(&cpu_hotplug.lock); @@ -87,6 +101,7 @@ void put_online_cpus(void) if (!--cpu_hotplug.refcount && unlikely(cpu_hotplug.active_writer)) wake_up_process(cpu_hotplug.active_writer); mutex_unlock(&cpu_hotplug.lock); + cpuhp_lock_release(); } EXPORT_SYMBOL_GPL(put_online_cpus); @@ -117,6 +132,7 @@ void cpu_hotplug_begin(void) { cpu_hotplug.active_writer = current; + cpuhp_lock_acquire(); for (;;) { mutex_lock(&cpu_hotplug.lock); if (likely(!cpu_hotplug.refcount)) @@ -131,6 +147,7 @@ void cpu_hotplug_done(void) { cpu_hotplug.active_writer = NULL; mutex_unlock(&cpu_hotplug.lock); + cpuhp_lock_release(); } /*
next prev parent reply other threads:[~2014-02-14 7:54 UTC|newest] Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-14 7:49 [PATCH v2 00/52] CPU hotplug: Fix issues with callback registration Srivatsa S. Bhat 2014-02-14 7:49 ` Srivatsa S. Bhat [this message] 2014-02-14 7:49 ` [PATCH v2 01/52] CPU hotplug: Add lockdep annotations to get/put_online_cpus() Srivatsa S. Bhat 2014-02-14 7:49 ` [PATCH v2 02/52] CPU hotplug: Provide lockless versions of callback registration functions Srivatsa S. Bhat 2014-02-14 7:49 ` Srivatsa S. Bhat 2014-02-17 13:26 ` Gautham R Shenoy 2014-02-19 21:34 ` Toshi Kani 2014-02-14 7:49 ` [PATCH v2 03/52] Doc/cpu-hotplug: Specify race-free way to register CPU hotplug callbacks Srivatsa S. Bhat 2014-02-14 7:49 ` Srivatsa S. Bhat 2014-02-14 7:49 ` [PATCH v2 04/52] CPU hotplug, perf: Fix CPU hotplug callback registration Srivatsa S. Bhat 2014-02-14 7:49 ` Srivatsa S. Bhat 2014-02-14 7:50 ` [PATCH v2 05/52] ia64, salinfo: Fix " Srivatsa S. Bhat 2014-02-14 7:50 ` Srivatsa S. Bhat 2014-02-14 7:50 ` [PATCH v2 06/52] ia64, palinfo: Fix CPU " Srivatsa S. Bhat 2014-02-14 7:50 ` Srivatsa S. Bhat 2014-02-14 7:50 ` [PATCH v2 07/52] ia64, topology: " Srivatsa S. Bhat 2014-02-14 7:50 ` Srivatsa S. Bhat 2014-02-14 7:50 ` [PATCH v2 08/52] ia64, err-inject: " Srivatsa S. Bhat 2014-02-14 7:50 ` Srivatsa S. Bhat 2014-02-14 7:51 ` [PATCH v2 09/52] arm, hw-breakpoint: " Srivatsa S. Bhat 2014-02-14 7:51 ` Srivatsa S. Bhat 2014-02-14 7:51 ` [PATCH v2 10/52] arm, kvm: " Srivatsa S. Bhat 2014-02-14 7:51 ` Srivatsa S. Bhat 2014-02-14 10:29 ` Paolo Bonzini 2014-02-14 10:29 ` Paolo Bonzini 2014-02-14 7:51 ` [PATCH v2 11/52] s390, cacheinfo: " Srivatsa S. Bhat 2014-02-14 7:51 ` Srivatsa S. Bhat 2014-02-14 7:51 ` [PATCH v2 12/52] s390, smp: " Srivatsa S. Bhat 2014-02-14 7:51 ` Srivatsa S. Bhat 2014-02-14 7:52 ` [PATCH v2 13/52] sparc, sysfs: " Srivatsa S. Bhat 2014-02-14 7:52 ` Srivatsa S. Bhat 2014-02-14 18:30 ` David Miller 2014-02-14 7:52 ` [PATCH v2 14/52] powerpc, " Srivatsa S. Bhat 2014-02-14 7:52 ` Srivatsa S. Bhat 2014-03-07 2:57 ` Benjamin Herrenschmidt 2014-03-07 2:57 ` Benjamin Herrenschmidt 2014-03-07 6:21 ` Gautham R Shenoy 2014-02-14 7:52 ` [PATCH v2 15/52] x86, msr: " Srivatsa S. Bhat 2014-02-14 7:52 ` Srivatsa S. Bhat 2014-02-14 7:52 ` [PATCH v2 16/52] x86, cpuid: " Srivatsa S. Bhat 2014-02-14 7:52 ` Srivatsa S. Bhat 2014-02-14 7:52 ` [PATCH v2 17/52] x86, vsyscall: " Srivatsa S. Bhat 2014-02-14 7:52 ` Srivatsa S. Bhat 2014-02-14 7:53 ` [PATCH v2 18/52] x86, intel, uncore: " Srivatsa S. Bhat 2014-02-14 7:53 ` Srivatsa S. Bhat 2014-02-14 7:53 ` [PATCH v2 19/52] x86, mce: " Srivatsa S. Bhat 2014-02-14 7:53 ` Srivatsa S. Bhat 2014-02-14 7:53 ` [PATCH v2 20/52] x86, therm_throt.c: " Srivatsa S. Bhat 2014-02-14 7:53 ` Srivatsa S. Bhat 2014-02-14 7:53 ` [PATCH v2 21/52] x86, therm_throt.c: Remove unused therm_cpu_lock Srivatsa S. Bhat 2014-02-14 7:53 ` Srivatsa S. Bhat 2014-02-14 7:54 ` [PATCH v2 22/52] x86, amd, ibs: Fix CPU hotplug callback registration Srivatsa S. Bhat 2014-02-14 7:54 ` Srivatsa S. Bhat 2014-02-14 7:54 ` [PATCH v2 23/52] x86, intel, cacheinfo: " Srivatsa S. Bhat 2014-02-14 7:54 ` Srivatsa S. Bhat 2014-02-14 7:54 ` [PATCH v2 24/52] x86, intel, rapl: " Srivatsa S. Bhat 2014-02-14 7:54 ` Srivatsa S. Bhat 2014-02-14 7:54 ` [PATCH v2 25/52] x86, amd, uncore: " Srivatsa S. Bhat 2014-02-14 7:54 ` Srivatsa S. Bhat 2014-02-14 7:55 ` [PATCH v2 26/52] x86, hpet: " Srivatsa S. Bhat 2014-02-14 7:55 ` Srivatsa S. Bhat 2014-02-14 7:55 ` [PATCH v2 27/52] x86, pci, amd-bus: " Srivatsa S. Bhat 2014-02-14 7:55 ` Srivatsa S. Bhat 2014-02-14 17:35 ` Bjorn Helgaas 2014-02-14 18:03 ` Srivatsa S. Bhat 2014-02-14 18:03 ` Srivatsa S. Bhat 2014-02-14 7:55 ` [PATCH v2 28/52] x86, oprofile, nmi: " Srivatsa S. Bhat 2014-02-14 7:55 ` Srivatsa S. Bhat 2014-02-14 7:55 ` [PATCH v2 29/52] x86, kvm: " Srivatsa S. Bhat 2014-02-14 7:55 ` Srivatsa S. Bhat 2014-02-14 10:29 ` Paolo Bonzini 2014-02-14 7:55 ` [PATCH v2 30/52] arm64, hw_breakpoint.c: " Srivatsa S. Bhat 2014-02-14 7:55 ` Srivatsa S. Bhat 2014-02-14 7:56 ` [PATCH v2 31/52] arm64, debug-monitors: " Srivatsa S. Bhat 2014-02-14 7:56 ` Srivatsa S. Bhat 2014-02-14 7:56 ` [PATCH v2 32/52] powercap, intel-rapl: " Srivatsa S. Bhat 2014-02-14 7:56 ` Srivatsa S. Bhat 2014-02-14 7:56 ` [PATCH v2 33/52] scsi, bnx2i: " Srivatsa S. Bhat 2014-02-14 7:56 ` Srivatsa S. Bhat 2014-02-14 7:56 ` [PATCH v2 34/52] scsi, bnx2fc: " Srivatsa S. Bhat 2014-02-14 7:56 ` Srivatsa S. Bhat 2014-02-14 7:57 ` [PATCH v2 35/52] scsi, fcoe: " Srivatsa S. Bhat 2014-02-14 7:57 ` Srivatsa S. Bhat 2014-02-14 7:57 ` [PATCH v2 36/52] zsmalloc: " Srivatsa S. Bhat 2014-02-14 7:57 ` Srivatsa S. Bhat 2014-02-14 7:57 ` [PATCH v2 37/52] acpi-cpufreq: " Srivatsa S. Bhat 2014-02-14 7:57 ` Srivatsa S. Bhat 2014-02-14 7:57 ` [PATCH v2 38/52] drivers/base/topology.c: " Srivatsa S. Bhat 2014-02-14 7:57 ` Srivatsa S. Bhat 2014-02-15 19:38 ` Greg Kroah-Hartman 2014-02-14 7:58 ` [PATCH v2 39/52] clocksource, dummy-timer: " Srivatsa S. Bhat 2014-02-14 7:58 ` Srivatsa S. Bhat 2014-02-14 7:58 ` [PATCH v2 40/52] intel-idle: " Srivatsa S. Bhat 2014-02-14 7:58 ` Srivatsa S. Bhat 2014-02-14 7:58 ` [PATCH v2 41/52] oprofile, nmi-timer: " Srivatsa S. Bhat 2014-02-14 7:58 ` Srivatsa S. Bhat 2014-02-14 7:58 ` [PATCH v2 42/52] octeon, watchdog: " Srivatsa S. Bhat 2014-02-14 7:58 ` Srivatsa S. Bhat 2014-02-14 7:58 ` [PATCH v2 43/52] thermal, x86-pkg-temp: " Srivatsa S. Bhat 2014-02-14 7:58 ` Srivatsa S. Bhat 2014-02-14 7:59 ` [PATCH v2 44/52] hwmon, coretemp: " Srivatsa S. Bhat 2014-02-14 7:59 ` Srivatsa S. Bhat 2014-02-14 7:59 ` [PATCH v2 45/52] hwmon, via-cputemp: " Srivatsa S. Bhat 2014-02-14 7:59 ` Srivatsa S. Bhat 2014-02-14 7:59 ` [PATCH v2 46/52] xen, balloon: " Srivatsa S. Bhat 2014-02-14 7:59 ` Srivatsa S. Bhat 2014-02-14 16:49 ` Boris Ostrovsky 2014-02-14 16:49 ` Boris Ostrovsky 2014-02-14 16:50 ` Srivatsa S. Bhat 2014-02-15 16:51 ` [UPDATED][PATCH " Srivatsa S. Bhat 2014-02-17 14:50 ` Boris Ostrovsky 2014-02-14 7:59 ` [PATCH v2 47/52] trace, ring-buffer: " Srivatsa S. Bhat 2014-02-14 7:59 ` Srivatsa S. Bhat 2014-02-14 8:00 ` [PATCH v2 48/52] profile: " Srivatsa S. Bhat 2014-02-14 8:00 ` Srivatsa S. Bhat 2014-02-14 8:00 ` [PATCH v2 49/52] mm, vmstat: " Srivatsa S. Bhat 2014-02-14 8:00 ` Srivatsa S. Bhat 2014-02-14 14:26 ` Rik van Riel 2014-02-14 14:26 ` Rik van Riel 2014-02-14 8:00 ` [PATCH v2 50/52] mm, zswap: " Srivatsa S. Bhat 2014-02-14 8:00 ` Srivatsa S. Bhat 2014-02-14 8:00 ` [PATCH v2 51/52] net/core/flow.c: " Srivatsa S. Bhat 2014-02-14 8:00 ` Srivatsa S. Bhat 2014-02-14 18:31 ` David Miller 2014-02-14 8:00 ` [PATCH v2 52/52] net/iucv/iucv.c: " Srivatsa S. Bhat 2014-02-14 8:00 ` Srivatsa S. Bhat 2014-02-14 18:31 ` David Miller 2014-02-18 8:56 ` [PATCH v2 00/52] CPU hotplug: Fix issues with " Srivatsa S. Bhat 2014-02-18 8:56 ` Srivatsa S. Bhat
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140214074913.22701.44704.stgit@srivatsabhat.in.ibm.com \ --to=srivatsa.bhat@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=ego@linux.vnet.ibm.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mingo@kernel.org \ --cc=oleg@redhat.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=rjw@rjwysocki.net \ --cc=rusty@rustcorp.com.au \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=walken@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).