From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org,
arnd@arndb.de, linux-kernel@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any more
Date: Wed, 19 Feb 2014 19:47:13 -0500 (EST) [thread overview]
Message-ID: <20140219.194713.1411547109743205257.davem@davemloft.net> (raw)
In-Reply-To: <20140212154559.2405.3104.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Wed, 12 Feb 2014 15:45:59 +0000
> sparc_cpu_model isn't in asm/system.h any more, so remove a comment about it.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
That's not all your patch does:
> - /* extern enum sparc_cpu sparc_cpu_model; */ /* in <asm/system.h> */
> - if (sparc_cpu_model != sun4m) {
> + if (sparc_cpu_model != sun4m)
> /* We must be on sun4m because we use MMU Bypass ASI. */
> return -ENXIO;
> - }
The basic block is more than one line, therefore the braces are
appropriate. Please do not remove them, and especially do not
remove them without mentioning them in the commit message.
Thanks.
next prev parent reply other threads:[~2014-02-20 0:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 15:45 [PATCH 0/4] Final asm/system.h cleanups David Howells
2014-02-12 15:45 ` [PATCH 1/4] Clean asm/system.h from docs David Howells
2014-02-12 15:45 ` David Howells
2014-02-12 15:45 ` [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any more David Howells
2014-02-12 15:45 ` David Howells
2014-02-20 0:47 ` David Miller [this message]
2014-02-20 16:08 ` [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any more [ver #2] David Howells
2014-02-20 18:34 ` David Miller
2014-02-20 18:34 ` David Miller
2014-02-12 15:46 ` [PATCH 3/4] UM: arch_align_stack() moved to asm/exec.h David Howells
2014-02-12 15:46 ` David Howells
2014-02-12 15:46 ` [PATCH 4/4] ARM: Delete asm/system.h David Howells
2014-02-12 15:46 ` David Howells
2014-02-12 16:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219.194713.1411547109743205257.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).