From: Josh Triplett <josh@joshtriplett.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] bug: Make BUG() call unreachable()
Date: Thu, 27 Feb 2014 16:16:45 -0800 [thread overview]
Message-ID: <20140228001645.GA29605@thin> (raw)
In-Reply-To: <201402272019.47554.arnd@arndb.de>
On Thu, Feb 27, 2014 at 08:19:47PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 February 2014, Josh Triplett wrote:
> > This doesn't seem any different than compiling out assert() at runtime
> > in a userspace program, given how the kernel uses BUG() and BUG_ON().
> > I'd argue that adding unreachable() doesn't seem like it makes the
> > current implementation of BUG() any worse; either way if you reach it
> > you have a problem.
>
> I think it's better to get a warning about undefined behavior than
> to suppress that warning.
Then at this point I'm going to suggest that you go ahead and submit the
patch you want on top of the first four patches of this series. Please
keep in mind the value and code size savings of !CONFIG_BUG, versus
CONFIG_BUG=y and !CONFIG_DEBUG_BUGVERBOSE; those mean two different
things.
Meanwhile: Andrew, could you go ahead and apply the first four patches?
- Josh Triplett
next prev parent reply other threads:[~2014-02-28 0:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 3:48 [PATCH v2 1/5] bug: When !CONFIG_BUG, simplify WARN_ON_ONCE and family Josh Triplett
2014-02-26 3:48 ` Josh Triplett
2014-02-26 3:48 ` [PATCH v2 2/5] include/asm-generic/bug.h: Style fix: s/while(0)/while (0)/ Josh Triplett
2014-02-26 3:48 ` Josh Triplett
2014-02-26 13:25 ` Arnd Bergmann
2014-02-26 13:25 ` Arnd Bergmann
2014-02-26 3:49 ` [PATCH v2 3/5] bug: When !CONFIG_BUG, make WARN call no_printk to check format and args Josh Triplett
2014-02-26 3:49 ` Josh Triplett
2014-02-26 13:25 ` Arnd Bergmann
2014-02-26 13:25 ` Arnd Bergmann
2014-02-26 3:49 ` [PATCH v2 4/5] bug: Use a common definition of BUG_ON regardless of CONFIG_BUG Josh Triplett
2014-02-26 3:49 ` Josh Triplett
2014-02-26 13:26 ` Arnd Bergmann
2014-02-26 3:49 ` [PATCH v2 5/5] bug: Make BUG() call unreachable() Josh Triplett
2014-02-26 3:49 ` Josh Triplett
2014-02-26 13:29 ` Arnd Bergmann
2014-02-26 13:29 ` Arnd Bergmann
2014-02-26 14:58 ` Josh Triplett
2014-02-26 14:58 ` Josh Triplett
2014-02-27 19:19 ` Arnd Bergmann
2014-02-28 0:16 ` Josh Triplett [this message]
2014-02-28 8:55 ` Arnd Bergmann
2014-03-10 1:00 ` [PATCH v3 1/5] bug: When !CONFIG_BUG, simplify WARN_ON_ONCE and family Josh Triplett
2014-03-10 1:01 ` [PATCH v3 2/5] include/asm-generic/bug.h: Style fix: s/while(0)/while (0)/ Josh Triplett
2014-03-10 1:02 ` [PATCH v3 3/5] bug: When !CONFIG_BUG, make WARN call no_printk to check format and args Josh Triplett
2014-03-10 1:02 ` Josh Triplett
2014-03-10 1:02 ` [PATCH v3 4/5] bug: Make BUG() always stop the machine Josh Triplett
2014-03-10 1:03 ` [PATCH v3 5/5] x86: Always define BUG() and HAVE_ARCH_BUG, even with !CONFIG_BUG Josh Triplett
2014-03-11 16:40 ` [PATCH v3 1/5] bug: When !CONFIG_BUG, simplify WARN_ON_ONCE and family Arnd Bergmann
2014-03-11 17:49 ` Josh Triplett
2014-03-11 17:49 ` Josh Triplett
2014-02-26 13:24 ` [PATCH v2 " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228001645.GA29605@thin \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).