From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 29/31] arch,xtensa: Convert smp_mb__* Date: Wed, 19 Mar 2014 14:30:30 +0100 Message-ID: <20140319133030.GA7744@laptop.programming.kicks-ass.net> References: <20140319064729.660482086@infradead.org> <20140319065205.319240141@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Max Filippov Cc: Linux-Arch , LKML , Linus Torvalds , Andrew Morton , Ingo Molnar , will.deacon@arm.com, Paul McKenney List-Id: linux-arch.vger.kernel.org On Wed, Mar 19, 2014 at 05:11:34PM +0400, Max Filippov wrote: > Hi Peter, > > On Wed, Mar 19, 2014 at 10:47 AM, Peter Zijlstra wrote: > > Xtensa SMP has ll/sc which is fully serializing, therefore its exising > > One minor correction: current xtensa ISA doens't have ll/sc, it only > has cas (s32c1i instruction), which is fully serializing. Oh; my bad in reading your asm. The l32i and s32cli read like a load 32 and store 32 conditional to me. But sure, cas works too :-) I'll ammend the changelog. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org ([205.233.59.134]:33828 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933830AbaCSNak (ORCPT ); Wed, 19 Mar 2014 09:30:40 -0400 Date: Wed, 19 Mar 2014 14:30:30 +0100 From: Peter Zijlstra Subject: Re: [PATCH 29/31] arch,xtensa: Convert smp_mb__* Message-ID: <20140319133030.GA7744@laptop.programming.kicks-ass.net> References: <20140319064729.660482086@infradead.org> <20140319065205.319240141@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Max Filippov Cc: Linux-Arch , LKML , Linus Torvalds , Andrew Morton , Ingo Molnar , will.deacon@arm.com, Paul McKenney Message-ID: <20140319133030.rGc-ErRCD0srqye-im3I95pQDeitooNCyGAnr1_-PJI@z> On Wed, Mar 19, 2014 at 05:11:34PM +0400, Max Filippov wrote: > Hi Peter, > > On Wed, Mar 19, 2014 at 10:47 AM, Peter Zijlstra wrote: > > Xtensa SMP has ll/sc which is fully serializing, therefore its exising > > One minor correction: current xtensa ISA doens't have ll/sc, it only > has cas (s32c1i instruction), which is fully serializing. Oh; my bad in reading your asm. The l32i and s32cli read like a load 32 and store 32 conditional to me. But sure, cas works too :-) I'll ammend the changelog. Thanks!