linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jump label: constify lookup functions
Date: Thu, 20 Mar 2014 13:13:52 -0400	[thread overview]
Message-ID: <20140320131352.560df1dd@gandalf.local.home> (raw)
In-Reply-To: <53235B15.7070807@oracle.com>

On Fri, 14 Mar 2014 15:40:05 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:

> ping?
> 
> On 02/12/2014 08:56 AM, Sasha Levin wrote:
> > ping?
> >
> > On 01/27/2014 02:27 PM, Sasha Levin wrote:
> >> Modify the parameters of all the lookup and the bookkeeping functions which
> >> should be const to const.
> >>
> >> For example, jump_label_text_reserved() doesn't modify the memory it works on,
> >> it just checks whether there are any jump labels there.
> >>
> >> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> >> ---
> >>   arch/arm/include/asm/jump_label.h     |  2 +-
> >>   arch/arm/kernel/jump_label.c          |  6 ++---
> >>   arch/arm64/include/asm/jump_label.h   |  2 +-
> >>   arch/arm64/kernel/jump_label.c        |  6 ++---
> >>   arch/mips/include/asm/jump_label.h    |  2 +-
> >>   arch/mips/kernel/jump_label.c         |  2 +-
> >>   arch/powerpc/include/asm/jump_label.h |  2 +-
> >>   arch/powerpc/kernel/jump_label.c      |  2 +-
> >>   arch/s390/include/asm/jump_label.h    |  2 +-
> >>   arch/s390/kernel/jump_label.c         | 12 ++++-----
> >>   arch/sparc/include/asm/jump_label.h   |  2 +-
> >>   arch/sparc/kernel/jump_label.c        |  2 +-
> >>   arch/x86/include/asm/jump_label.h     |  2 +-
> >>   arch/x86/include/asm/spinlock.h       |  2 +-
> >>   arch/x86/kernel/jump_label.c          |  6 ++---

The arch changes should be broken up per arch. They are not dependent
on each other, and they require being either acked by or pulled in by
the architecture maintainers.

> >>   include/linux/jump_label.h            | 27 ++++++++++----------
> >>   kernel/jump_label.c                   | 46 ++++++++++++++++++-----------------
> >>   17 files changed, 64 insertions(+), 61 deletions(-)

The jump label generic patch should also be by itself, and that I can
take.

-- Steve

      reply	other threads:[~2014-03-20 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 19:27 [PATCH] jump label: constify lookup functions Sasha Levin
2014-02-12 13:56 ` Sasha Levin
2014-03-14 19:40   ` Sasha Levin
2014-03-20 17:13     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320131352.560df1dd@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).