From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation Date: Fri, 4 Apr 2014 19:54:52 +0200 Message-ID: <20140404175452.GB25949@gmail.com> References: <1396445259-27670-1-git-send-email-Waiman.Long@hp.com> <1396445259-27670-2-git-send-email-Waiman.Long@hp.com> <20140404130012.GE10526@twins.programming.kicks-ass.net> <20140404165727.GQ19478@phenom.dumpdata.com> <533EE700.4080408@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <533EE700.4080408@hp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Waiman Long Cc: x86@kernel.org, Gleb Natapov , Peter Zijlstra , virtualization@lists.linux-foundation.org, Marcos Matsunaga , "H. Peter Anvin" , linux-arch@vger.kernel.org, kvm@vger.kernel.org, Raghavendra K T , Ingo Molnar , xen-devel@lists.xenproject.org, "Paul E. McKenney" , Rik van Riel , Konrad Rzeszutek Wilk , Scott J Norton , Paolo Bonzini , Oleg Nesterov , Thomas Gleixner , Aswin Chandramouleeswaran , Chegu Vinod , linux-kernel@vger.kernel.org, David Vrabel , Linus Torvalds List-Id: linux-arch.vger.kernel.org * Waiman Long wrote: > On 04/04/2014 12:57 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: > >>So I'm just not ever going to pick up this patch; I spend a week trying > >>to reverse engineer this; I posted a 7 patch series creating the > >>equivalent, but in a gradual and readable fashion: > >> > >> http://lkml.kernel.org/r/20140310154236.038181843@infradead.org > >> > >>You keep on ignoring that; I'll keep on ignoring your patches. > >> > >>I might at some point rewrite some of your pv stuff on top to get this > >>moving again, but I'm not really motivated to work with you atm. > >Uh? Did you CC also xen-devel@lists.xenproject.org on your patches Peter? > >I hadn't had a chance to see or comment on them :-( > > > > Peter's patch is a rewrite of my patches 1-4, there is no PV or > unfair lock support in there. It is a fine grained split-up, which does one thing at a time, so it all becomes reviewable and mergable (and the claimed effects become testable!). Please use that as a base. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:43788 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbaDDRy6 (ORCPT ); Fri, 4 Apr 2014 13:54:58 -0400 Date: Fri, 4 Apr 2014 19:54:52 +0200 From: Ingo Molnar Subject: Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation Message-ID: <20140404175452.GB25949@gmail.com> References: <1396445259-27670-1-git-send-email-Waiman.Long@hp.com> <1396445259-27670-2-git-send-email-Waiman.Long@hp.com> <20140404130012.GE10526@twins.programming.kicks-ass.net> <20140404165727.GQ19478@phenom.dumpdata.com> <533EE700.4080408@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533EE700.4080408@hp.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Waiman Long Cc: Konrad Rzeszutek Wilk , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Paolo Bonzini , "Paul E. McKenney" , Rik van Riel , Linus Torvalds , Raghavendra K T , David Vrabel , Oleg Nesterov , Gleb Natapov , Aswin Chandramouleeswaran , Scott J Norton , Chegu Vinod , Marcos Matsunaga Message-ID: <20140404175452.P8G-gWcRdsaU_0SlopWqpy_LtfVFGEK8Q8l2FNS-Tks@z> * Waiman Long wrote: > On 04/04/2014 12:57 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: > >>So I'm just not ever going to pick up this patch; I spend a week trying > >>to reverse engineer this; I posted a 7 patch series creating the > >>equivalent, but in a gradual and readable fashion: > >> > >> http://lkml.kernel.org/r/20140310154236.038181843@infradead.org > >> > >>You keep on ignoring that; I'll keep on ignoring your patches. > >> > >>I might at some point rewrite some of your pv stuff on top to get this > >>moving again, but I'm not really motivated to work with you atm. > >Uh? Did you CC also xen-devel@lists.xenproject.org on your patches Peter? > >I hadn't had a chance to see or comment on them :-( > > > > Peter's patch is a rewrite of my patches 1-4, there is no PV or > unfair lock support in there. It is a fine grained split-up, which does one thing at a time, so it all becomes reviewable and mergable (and the claimed effects become testable!). Please use that as a base. Thanks, Ingo