From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Date: Mon, 19 May 2014 16:43:01 -0700 Message-ID: <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Hugh Dickins Cc: linux-arch@vger.kernel.org, x86@kernel.org, riel@redhat.com, Madhavan Srinivasan , dave.hansen@intel.com, peterz@infradead.org, Rusty Russell , linux-kernel@vger.kernel.org, linux-mm@kvack.org, ak@linux.intel.com, paulus@samba.org, mgorman@suse.de, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, "Kirill A. Shutemov" List-Id: linux-arch.vger.kernel.org T24gTW9uLCAxOSBNYXkgMjAxNCAxNjoyMzowNyAtMDcwMCAoUERUKSBIdWdoIERpY2tpbnMgPGh1 Z2hkQGdvb2dsZS5jb20+IHdyb3RlOgoKPiBTaG91bGRuJ3QgRkFVTFRfQVJPVU5EX09SREVSIGFu ZCBmYXVsdF9hcm91bmRfb3JkZXIgYmUgY2hhbmdlZCB0byBiZQo+IHRoZSBvcmRlciBvZiB0aGUg ZmF1bHQtYXJvdW5kIHNpemUgaW4gYnl0ZXMsIGFuZCBmYXVsdF9hcm91bmRfcGFnZXMoKQo+IHVz ZSAxVUwgPDwgKGZhdWx0X2Fyb3VuZF9vcmRlciAtIFBBR0VfU0hJRlQpCgpZZXMuICBBbmQgc2hh bWUgb24gbWUgZm9yIG1pc3NpbmcgaXQgKHRoaXMgdGltZSEpIGF0IHJldmlldy4KClRoZXJlJ3Mg c3RpbGwgdGltZSB0byBmaXggdGhpcy4gIFBhdGNoZXMsIHBsZWFzZS4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlz dApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcv bGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:50654 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbaESXnD (ORCPT ); Mon, 19 May 2014 19:43:03 -0400 Date: Mon, 19 May 2014 16:43:01 -0700 From: Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Message-ID: <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> In-Reply-To: References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Hugh Dickins Cc: Madhavan Srinivasan , Rusty Russell , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Message-ID: <20140519234301.0QAstrhkTC-Qgfvh1qmRbrpljBFCn3KzoKOLJJ-9gAs@z> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > the order of the fault-around size in bytes, and fault_around_pages() > use 1UL << (fault_around_order - PAGE_SHIFT) Yes. And shame on me for missing it (this time!) at review. There's still time to fix this. Patches, please.