From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Date: Tue, 20 May 2014 00:32:01 -0700 Message-ID: <20140520003201.a2360d5d.akpm@linux-foundation.org> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> <87oaythsvk.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87oaythsvk.fsf@rustcorp.com.au> Sender: owner-linux-mm@kvack.org To: Rusty Russell Cc: "Kirill A. Shutemov" , Hugh Dickins , Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com List-Id: linux-arch.vger.kernel.org On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell wrote: > "Kirill A. Shutemov" writes: > > Andrew Morton wrote: > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > >> > >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > >> > the order of the fault-around size in bytes, and fault_around_pages() > >> > use 1UL << (fault_around_order - PAGE_SHIFT) > >> > >> Yes. And shame on me for missing it (this time!) at review. > >> > >> There's still time to fix this. Patches, please. > > > > Here it is. Made at 3.30 AM, build tested only. > > Prefer on top of Maddy's patch which makes it always a variable, rather > than CONFIG_DEBUG_FS. It's got enough hair as it is. > We're at 3.15-rc5 and this interface should be finalised for 3.16. So Kirrill's patch is pretty urgent and should come first. Well. It's only a debugfs interface at this stage so we are allowed to change it later, but it's better not to. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53632 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbaETHcX (ORCPT ); Tue, 20 May 2014 03:32:23 -0400 Date: Tue, 20 May 2014 00:32:01 -0700 From: Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Message-ID: <20140520003201.a2360d5d.akpm@linux-foundation.org> In-Reply-To: <87oaythsvk.fsf@rustcorp.com.au> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> <87oaythsvk.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rusty Russell Cc: "Kirill A. Shutemov" , Hugh Dickins , Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Message-ID: <20140520073201.qxtJQ2dlNRVdqYZDS7X-jhM_IbwXYn4uGIxWND87uOA@z> On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell wrote: > "Kirill A. Shutemov" writes: > > Andrew Morton wrote: > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > >> > >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > >> > the order of the fault-around size in bytes, and fault_around_pages() > >> > use 1UL << (fault_around_order - PAGE_SHIFT) > >> > >> Yes. And shame on me for missing it (this time!) at review. > >> > >> There's still time to fix this. Patches, please. > > > > Here it is. Made at 3.30 AM, build tested only. > > Prefer on top of Maddy's patch which makes it always a variable, rather > than CONFIG_DEBUG_FS. It's got enough hair as it is. > We're at 3.15-rc5 and this interface should be finalised for 3.16. So Kirrill's patch is pretty urgent and should come first. Well. It's only a debugfs interface at this stage so we are allowed to change it later, but it's better not to.