From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 14/18] sparc: io: implement dummy relaxed accessor macros for writes Date: Fri, 23 May 2014 15:38:10 +0100 Message-ID: <20140523143810.GE21319@arm.com> References: <1400777250-17335-1-git-send-email-will.deacon@arm.com> <1400777250-17335-15-git-send-email-will.deacon@arm.com> <20140522181838.GA30632@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140522181838.GA30632@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org To: Sam Ravnborg Cc: "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "monstr@monstr.eu" , "dhowells@redhat.com" , "broonie@linaro.org" , "benh@kernel.crashing.org" , "peterz@infradead.org" , "paulmck@linux.vnet.ibm.com" , "David S. Miller" List-Id: linux-arch.vger.kernel.org On Thu, May 22, 2014 at 07:18:38PM +0100, Sam Ravnborg wrote: > On Thu, May 22, 2014 at 05:47:26PM +0100, Will Deacon wrote: > > write{b,w,l,q}_relaxed are implemented by some architectures in order to > > permit memory-mapped I/O accesses with weaker barrier semantics than the > > non-relaxed variants. > > > > This patch adds dummy macros for the write accessors to sparc, in the > > same vein as the dummy definitions for the relaxed read accessors. The > > existing relaxed read{b,w,l} accessors are moved into asm/io.h, since > > they are identical between 32-bit and 64-bit machines. > > > > Cc: "David S. Miller" > > Signed-off-by: Will Deacon > Look good: > Acked-by: Sam Ravnborg Thanks, Sam. > But you should wait for David's ack too. Yeah, I still need to get buy-in on the semantics from the PPC folks anyway. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:47206 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbaEWOjG (ORCPT ); Fri, 23 May 2014 10:39:06 -0400 Date: Fri, 23 May 2014 15:38:10 +0100 From: Will Deacon Subject: Re: [PATCH v2 14/18] sparc: io: implement dummy relaxed accessor macros for writes Message-ID: <20140523143810.GE21319@arm.com> References: <1400777250-17335-1-git-send-email-will.deacon@arm.com> <1400777250-17335-15-git-send-email-will.deacon@arm.com> <20140522181838.GA30632@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140522181838.GA30632@ravnborg.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Sam Ravnborg Cc: "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "monstr@monstr.eu" , "dhowells@redhat.com" , "broonie@linaro.org" , "benh@kernel.crashing.org" , "peterz@infradead.org" , "paulmck@linux.vnet.ibm.com" , "David S. Miller" Message-ID: <20140523143810.NuAMrMuA5Fcm1h7yWo9Eh7VNL9jqa3XQ-y6SXhwho1I@z> On Thu, May 22, 2014 at 07:18:38PM +0100, Sam Ravnborg wrote: > On Thu, May 22, 2014 at 05:47:26PM +0100, Will Deacon wrote: > > write{b,w,l,q}_relaxed are implemented by some architectures in order to > > permit memory-mapped I/O accesses with weaker barrier semantics than the > > non-relaxed variants. > > > > This patch adds dummy macros for the write accessors to sparc, in the > > same vein as the dummy definitions for the relaxed read accessors. The > > existing relaxed read{b,w,l} accessors are moved into asm/io.h, since > > they are identical between 32-bit and 64-bit machines. > > > > Cc: "David S. Miller" > > Signed-off-by: Will Deacon > Look good: > Acked-by: Sam Ravnborg Thanks, Sam. > But you should wait for David's ack too. Yeah, I still need to get buy-in on the semantics from the PPC folks anyway. Will