From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags Date: Wed, 25 Jun 2014 15:43:54 +0200 Message-ID: <20140625134354.GA7892@redhat.com> References: <1403642893-23107-1-git-send-email-keescook@chromium.org> <1403642893-23107-5-git-send-email-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1403642893-23107-5-git-send-email-keescook@chromium.org> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , "Michael Kerrisk (man-pages)" , Alexei Starovoitov , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , linux-api@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-arch@vger.kernel.org, linux-security-module@vger.kernel.org List-Id: linux-arch.vger.kernel.org On 06/24, Kees Cook wrote: > > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1307,8 +1307,7 @@ struct task_struct { > * execve */ > unsigned in_iowait:1; > > - /* task may not gain privileges */ > - unsigned no_new_privs:1; > + unsigned long atomic_flags; /* Flags needing atomic access. */ > > /* Revert to default priority/policy when forking */ > unsigned sched_reset_on_fork:1; Agreed, personally I like it more than seccomp->flags. But probably it would be better to place the new member before/after other bitfields to save the space? Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:14265 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756944AbaFYNqY (ORCPT ); Wed, 25 Jun 2014 09:46:24 -0400 Date: Wed, 25 Jun 2014 15:43:54 +0200 From: Oleg Nesterov Subject: Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags Message-ID: <20140625134354.GA7892@redhat.com> References: <1403642893-23107-1-git-send-email-keescook@chromium.org> <1403642893-23107-5-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403642893-23107-5-git-send-email-keescook@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , "Michael Kerrisk (man-pages)" , Alexei Starovoitov , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , linux-api@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-arch@vger.kernel.org, linux-security-module@vger.kernel.org Message-ID: <20140625134354.Vl3d7isPtoGt4JFKElzfSJmJrYqhIEKYm9CUnP0LzWQ@z> On 06/24, Kees Cook wrote: > > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1307,8 +1307,7 @@ struct task_struct { > * execve */ > unsigned in_iowait:1; > > - /* task may not gain privileges */ > - unsigned no_new_privs:1; > + unsigned long atomic_flags; /* Flags needing atomic access. */ > > /* Revert to default priority/policy when forking */ > unsigned sched_reset_on_fork:1; Agreed, personally I like it more than seccomp->flags. But probably it would be better to place the new member before/after other bitfields to save the space? Oleg.