From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [RFA][PATCH 24/27] Blackfin: ftrace: Remove check of obsolete variable function_trace_stop Date: Thu, 26 Jun 2014 15:34:32 -0400 Message-ID: <20140626153432.69dbb7ca@gandalf.local.home> References: <20140626165221.736847419@goodmis.org> <20140626165853.211937817@goodmis.org> <3144266.ziutPk5CNZ@vapier> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3144266.ziutPk5CNZ@vapier> Sender: linux-kernel-owner@vger.kernel.org To: Mike Frysinger Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Masami Hiramatsu , "H. Peter Anvin" , linux-arch@vger.kernel.org, "Rafael J. Wysocki" , Jiri Kosina , Josh Poimboeuf List-Id: linux-arch.vger.kernel.org On Thu, 26 Jun 2014 15:25:31 -0400 Mike Frysinger wrote: > On Thu 26 Jun 2014 12:52:45 Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Nothing sets function_trace_stop to disable function tracing anymore. > > Remove the check for it in the arch code. > > > > [ Please test this on your arch ] > > i haven't tested, but the asm looks correct -- it's only using scratch > registers, and the rest of the code doesn't rely on the state in that ifdef > (by design). > > Acked-by: Mike Frysinger > -mike Thanks! -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.231]:54271 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750878AbaFZTeg (ORCPT ); Thu, 26 Jun 2014 15:34:36 -0400 Date: Thu, 26 Jun 2014 15:34:32 -0400 From: Steven Rostedt Subject: Re: [RFA][PATCH 24/27] Blackfin: ftrace: Remove check of obsolete variable function_trace_stop Message-ID: <20140626153432.69dbb7ca@gandalf.local.home> In-Reply-To: <3144266.ziutPk5CNZ@vapier> References: <20140626165221.736847419@goodmis.org> <20140626165853.211937817@goodmis.org> <3144266.ziutPk5CNZ@vapier> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mike Frysinger Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Masami Hiramatsu , "H. Peter Anvin" , linux-arch@vger.kernel.org, "Rafael J. Wysocki" , Jiri Kosina , Josh Poimboeuf Message-ID: <20140626193432.YZvlU-BjtdiK1JGbGAQz_QbvDo1IObMWX5UCDntFdyk@z> On Thu, 26 Jun 2014 15:25:31 -0400 Mike Frysinger wrote: > On Thu 26 Jun 2014 12:52:45 Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Nothing sets function_trace_stop to disable function tracing anymore. > > Remove the check for it in the arch code. > > > > [ Please test this on your arch ] > > i haven't tested, but the asm looks correct -- it's only using scratch > registers, and the rest of the code doesn't rely on the state in that ifdef > (by design). > > Acked-by: Mike Frysinger > -mike Thanks! -- Steve