From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-arch@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jiri Kosina <jkosina@suse.cz>,
Josh Poimboeuf <notifications@github.com>
Subject: [RFA][PATCH 15/27] ftrace: Remove check for HAVE_FUNCTION_TRACE_MCOUNT_TEST
Date: Thu, 26 Jun 2014 12:52:36 -0400 [thread overview]
Message-ID: <20140626165851.536020319@goodmis.org> (raw)
In-Reply-To: 20140626165221.736847419@goodmis.org
[-- Attachment #1: 0015-ftrace-Remove-check-for-HAVE_FUNCTION_TRACE_MCOUNT_T.patch --]
[-- Type: text/plain, Size: 2419 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
function_trace_stop is no longer used to disable function tracing.
This means that archs are no longer limited if it does not support
checking this variable in the mcount trampoline.
No need to use the list_func for archs that do not support this
obsolete method.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
Documentation/trace/ftrace-design.txt | 26 --------------------------
include/linux/ftrace.h | 3 +--
2 files changed, 1 insertion(+), 28 deletions(-)
diff --git a/Documentation/trace/ftrace-design.txt b/Documentation/trace/ftrace-design.txt
index 3f669b9e8852..dd5f916b351d 100644
--- a/Documentation/trace/ftrace-design.txt
+++ b/Documentation/trace/ftrace-design.txt
@@ -102,30 +102,6 @@ extern void mcount(void);
EXPORT_SYMBOL(mcount);
-HAVE_FUNCTION_TRACE_MCOUNT_TEST
--------------------------------
-
-This is an optional optimization for the normal case when tracing is turned off
-in the system. If you do not enable this Kconfig option, the common ftrace
-code will take care of doing the checking for you.
-
-To support this feature, you only need to check the function_trace_stop
-variable in the mcount function. If it is non-zero, there is no tracing to be
-done at all, so you can return.
-
-This additional pseudo code would simply be:
-void mcount(void)
-{
- /* save any bare state needed in order to do initial checking */
-
-+ if (function_trace_stop)
-+ return;
-
- extern void (*ftrace_trace_function)(unsigned long, unsigned long);
- if (ftrace_trace_function != ftrace_stub)
-...
-
-
HAVE_FUNCTION_GRAPH_TRACER
--------------------------
@@ -328,8 +304,6 @@ void mcount(void)
void ftrace_caller(void)
{
- /* implement HAVE_FUNCTION_TRACE_MCOUNT_TEST if you desire */
-
/* save all state needed by the ABI (see paragraph above) */
unsigned long frompc = ...;
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index d74a37d53271..7a21d5358b74 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -33,8 +33,7 @@
* features, then it must call an indirect function that
* does. Or at least does enough to prevent any unwelcomed side effects.
*/
-#if !defined(CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST) || \
- !ARCH_SUPPORTS_FTRACE_OPS
+#if !ARCH_SUPPORTS_FTRACE_OPS
# define FTRACE_FORCE_LIST_FUNC 1
#else
# define FTRACE_FORCE_LIST_FUNC 0
--
2.0.0
next prev parent reply other threads:[~2014-06-26 16:52 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 16:52 [RFA][PATCH 00/27] ftrace: Remove ftrace_start/stop() and friends Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 01/27] x86, power, suspend: Annotate restore_processor_state() with notrace Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-28 0:02 ` Rafael J. Wysocki
2014-06-26 16:52 ` [RFA][PATCH 02/27] PM / Sleep: Remove ftrace_stop/start() from suspend and hibernate Steven Rostedt
2014-06-28 0:02 ` Rafael J. Wysocki
2014-06-26 16:52 ` [RFA][PATCH 03/27] tracing: Remove ftrace_stop/start() from reading the trace file Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 04/27] ftrace-graph: Remove dependency of ftrace_stop() from ftrace_graph_stop() Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 05/27] ftrace/x86: Add call to ftrace_graph_is_dead() in function graph code Steven Rostedt
2014-07-15 15:47 ` H. Peter Anvin
2014-06-26 16:52 ` [RFA][PATCH 06/27] microblaze: ftrace: " Steven Rostedt
2014-07-03 16:34 ` Steven Rostedt
2014-07-03 16:34 ` Steven Rostedt
2014-07-09 14:03 ` Steven Rostedt
2014-07-18 8:19 ` Michal Simek
2014-07-18 8:19 ` Michal Simek
2014-06-26 16:52 ` [RFA][PATCH 07/27] MIPS: " Steven Rostedt
2014-07-02 14:31 ` Steven Rostedt
2014-07-02 14:31 ` Steven Rostedt
2014-07-09 15:48 ` James Hogan
2014-07-03 16:36 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 08/27] parisc: " Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 09/27] powerpc/ftrace: " Steven Rostedt
2014-07-09 14:04 ` Steven Rostedt
2014-07-09 14:04 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 10/27] sh: ftrace: " Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 11/27] ftrace-graph: Remove usage of ftrace_stop() in ftrace_graph_stop() Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 12/27] ftrace: Remove ftrace_start/stop() Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 13/27] ftrace: Do no disable function tracing on enabling function tracing Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 14/27] ftrace: Remove function_trace_stop check from list func Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt [this message]
2014-06-26 16:52 ` [RFA][PATCH 15/27] ftrace: Remove check for HAVE_FUNCTION_TRACE_MCOUNT_TEST Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 16/27] ftrace: x86: Remove check of obsolete variable function_trace_stop Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-07-15 15:48 ` H. Peter Anvin
2014-06-26 16:52 ` [RFA][PATCH 17/27] tile: ftrace: " Steven Rostedt
2014-06-26 17:33 ` Steven Rostedt
2014-06-26 17:33 ` Steven Rostedt
2014-07-03 13:53 ` Chris Metcalf
2014-07-03 14:02 ` Steven Rostedt
2014-07-03 14:02 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 18/27] sparc64,ftrace: " Steven Rostedt
2014-06-26 17:34 ` Steven Rostedt
2014-06-26 17:34 ` Steven Rostedt
2014-07-03 16:41 ` Steven Rostedt
2014-07-03 16:41 ` Steven Rostedt
2014-07-04 4:18 ` David Miller
2014-06-26 16:52 ` [RFA][PATCH 19/27] sh: ftrace: " Steven Rostedt
2014-06-26 17:35 ` Steven Rostedt
2014-06-26 17:35 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 20/27] parisc: " Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 17:35 ` Steven Rostedt
2014-06-29 21:20 ` Helge Deller
2014-06-30 14:11 ` Steven Rostedt
2014-06-30 14:11 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 21/27] MIPS: " Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 17:37 ` Steven Rostedt
2014-06-26 17:37 ` Steven Rostedt
2014-07-02 14:32 ` Steven Rostedt
2014-07-02 14:32 ` Steven Rostedt
2014-07-09 14:15 ` Steven Rostedt
2014-07-15 21:58 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 22/27] microblaze: " Steven Rostedt
2014-06-26 17:38 ` Steven Rostedt
2014-06-26 17:38 ` Steven Rostedt
2014-07-09 14:16 ` Steven Rostedt
2014-07-09 14:16 ` Steven Rostedt
2014-07-15 21:51 ` Steven Rostedt
2014-07-18 8:17 ` Michal Simek
2014-07-18 8:17 ` Michal Simek
2014-06-26 16:52 ` [RFA][PATCH 23/27] metag: " Steven Rostedt
2014-06-26 17:38 ` Steven Rostedt
2014-06-26 17:38 ` Steven Rostedt
2014-07-02 13:34 ` James Hogan
2014-07-02 14:22 ` Steven Rostedt
2014-07-02 14:22 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 24/27] Blackfin: " Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 17:39 ` Steven Rostedt
2014-06-26 17:39 ` Steven Rostedt
2014-06-26 19:25 ` Mike Frysinger
2014-06-26 19:34 ` Steven Rostedt
2014-06-26 19:34 ` Steven Rostedt
2014-06-26 16:52 ` [RFA][PATCH 25/27] arm64, " Steven Rostedt
2014-06-26 17:40 ` Steven Rostedt
2014-06-26 17:40 ` Steven Rostedt
2014-06-27 12:44 ` Will Deacon
2014-07-01 11:33 ` AKASHI Takahiro
2014-06-26 16:52 ` [RFA][PATCH 26/27] s390/ftrace: remove " Steven Rostedt
2014-06-26 16:52 ` Steven Rostedt
2014-06-26 17:41 ` Steven Rostedt
2014-06-26 17:41 ` Steven Rostedt
2014-06-27 6:01 ` Heiko Carstens
2014-06-26 16:52 ` [RFA][PATCH 27/27] tracing: Remove function_trace_stop and HAVE_FUNCTION_TRACE_MCOUNT_TEST Steven Rostedt
2014-06-30 3:13 ` [RFA][PATCH 00/27] ftrace: Remove ftrace_start/stop() and friends Masami Hiramatsu
2014-06-30 3:13 ` Masami Hiramatsu
2014-06-30 14:16 ` Steven Rostedt
2014-06-30 14:16 ` Steven Rostedt
2014-07-01 0:58 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626165851.536020319@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=notifications@github.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).