From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 0/9] Updated fence patch series Date: Tue, 1 Jul 2014 22:37:58 -0700 Message-ID: <20140702053758.GA7578@kroah.com> References: <20140701103432.12718.82795.stgit@patser> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140701103432.12718.82795.stgit@patser> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: linux-arch@vger.kernel.org, thellstrom@vmware.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, ccross@google.com, linux-media@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Tue, Jul 01, 2014 at 12:57:02PM +0200, Maarten Lankhorst wrote: > So after some more hacking I've moved dma-buf to its own subdirectory, > drivers/dma-buf and applied the fence patches to its new place. I believe that the > first patch should be applied regardless, and the rest should be ready now. > :-) > > Changes to the fence api: > - release_fence -> fence_release etc. > - __fence_init -> fence_init > - __fence_signal -> fence_signal_locked > - __fence_is_signaled -> fence_is_signaled_locked > - Changing BUG_ON to WARN_ON in fence_later, and return NULL if it triggers. > > Android can expose fences to userspace. It's possible to make the new fence > mechanism expose the same fences to userspace by changing sync_fence_create > to take a struct fence instead of a struct sync_pt. No other change is needed, > because only the fence parts of struct sync_pt are used. But because the > userspace fences are a separate problem and I haven't really looked at it yet > I feel it should stay in staging, for now. Ok, that's reasonable. At first glance, this all looks "sane" to me, any objection from anyone if I merge this through my driver-core tree for 3.17? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57269 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbaGBFiS (ORCPT ); Wed, 2 Jul 2014 01:38:18 -0400 Date: Tue, 1 Jul 2014 22:37:58 -0700 From: Greg KH Subject: Re: [PATCH v2 0/9] Updated fence patch series Message-ID: <20140702053758.GA7578@kroah.com> References: <20140701103432.12718.82795.stgit@patser> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140701103432.12718.82795.stgit@patser> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Maarten Lankhorst Cc: linux-arch@vger.kernel.org, thellstrom@vmware.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, robdclark@gmail.com, thierry.reding@gmail.com, ccross@google.com, daniel@ffwll.ch, sumit.semwal@linaro.org, linux-media@vger.kernel.org Message-ID: <20140702053758.RrrvTZZVd-ZcsGwi83EgFINX1KWk5X_N08vGUTzPEe8@z> On Tue, Jul 01, 2014 at 12:57:02PM +0200, Maarten Lankhorst wrote: > So after some more hacking I've moved dma-buf to its own subdirectory, > drivers/dma-buf and applied the fence patches to its new place. I believe that the > first patch should be applied regardless, and the rest should be ready now. > :-) > > Changes to the fence api: > - release_fence -> fence_release etc. > - __fence_init -> fence_init > - __fence_signal -> fence_signal_locked > - __fence_is_signaled -> fence_is_signaled_locked > - Changing BUG_ON to WARN_ON in fence_later, and return NULL if it triggers. > > Android can expose fences to userspace. It's possible to make the new fence > mechanism expose the same fences to userspace by changing sync_fence_create > to take a struct fence instead of a struct sync_pt. No other change is needed, > because only the fence parts of struct sync_pt are used. But because the > userspace fences are a separate problem and I haven't really looked at it yet > I feel it should stay in staging, for now. Ok, that's reasonable. At first glance, this all looks "sane" to me, any objection from anyone if I merge this through my driver-core tree for 3.17? thanks, greg k-h