From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 1/3] asm-generic/io.h: Implement generic {read,write}s*() Date: Wed, 9 Jul 2014 19:38:34 +0200 Message-ID: <20140709173834.GA31974@ravnborg.org> References: <1404918699-17284-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from asavdk4.altibox.net ([109.247.116.15]:46019 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbaGIRiw (ORCPT ); Wed, 9 Jul 2014 13:38:52 -0400 Content-Disposition: inline In-Reply-To: <1404918699-17284-1-git-send-email-thierry.reding@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thierry Reding Cc: Russell King , Catalin Marinas , Will Deacon , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jul 09, 2014 at 05:11:37PM +0200, Thierry Reding wrote: > From: Thierry Reding > > This patch implements generic versions of readsb(), readsw(), readsl(), > readsq(), writesb(), writesw(), writesl() and writesq(). Variants of > these string functions for I/O accesses (ins*() and outs*() as well as > ioread*_rep() and iowrite*_rep()) are now implemented in terms of the > new functions. > > While at it, also make sure that any of the functions provided as > fallback for architectures that don't override them can't be overridden > subsequently. > > This is compile- and runtime-tested on 32-bit and 64-bit ARM and compile > tested on Microblaze, s390, SPARC and Xtensa. For ARC, Blackfin, Metag, > OpenRISC, Score and Unicore32 which also use asm-generic/io.h I couldn't > find or build a cross-compiler that would run on my system. But by code > inspection they shouldn't break with this patch. Looks good. When this is in mainline I will try to convert sparc64 to use asm-generic/io.h too. Last I tried this did not fly because there were some #define missing and then I lost track of it. Sam