linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*()
Date: Sat, 19 Jul 2014 10:41:52 +0200	[thread overview]
Message-ID: <20140719084152.GA31564@ravnborg.org> (raw)
In-Reply-To: <43703371.jktNRIezc3@wuerfel>

> > 
> > This set:
> > #define inb_p(addr)     inb(addr)
> > #define inw_p(addr)     inw(addr)
> > #define inl_p(addr)     inl(addr)
> > #define outb_p(x, addr) outb((x), (addr))
> > #define outw_p(x, addr) outw((x), (addr))
> > #define outl_p(x, addr) outl((x), (addr))
> > 
> > Should have a comment that say they are deprecated.
> > Especially the "b" variants still have many users.
> 
> Are they? I don't remember ever seeing a reason to deprecate
> them. We could perhaps enclose them in #ifdef CONFIG_ISA, but
> there may also be some drivers that use the same code for ISA
> and PCI, and it doesn't really hurt on PCI.

It is my understanding that inl and inl_p are the same these days.
A quick grep indicate that only m68k define the
_p variant different from the other.
But I failed to find and description of the difference between the
two which is why I assumed they were identical and thus no need for both.


	Sam

  reply	other threads:[~2014-07-19  8:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 11:01 [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-16 11:01 ` [PATCH v3 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-16 11:01   ` Thierry Reding
2014-07-17 12:03   ` Catalin Marinas
2014-07-16 11:01 ` [PATCH v3 3/3] arm64: " Thierry Reding
2014-07-17 12:04   ` Catalin Marinas
2014-07-17 12:26     ` Thierry Reding
2014-07-18 15:50       ` Catalin Marinas
2014-07-17 12:01 ` [PATCH v3 1/3] asm-generic/io.h: Implement generic {read,write}s*() Catalin Marinas
2014-07-18 20:59 ` Sam Ravnborg
2014-07-18 20:59   ` Sam Ravnborg
2014-07-18 21:06   ` Sam Ravnborg
2014-07-18 21:06     ` Sam Ravnborg
2014-07-19  7:38     ` Arnd Bergmann
2014-07-19  8:41       ` Sam Ravnborg [this message]
2014-07-19  8:41         ` Sam Ravnborg
2014-07-19  9:05         ` Arnd Bergmann
2014-07-19  9:11           ` Sam Ravnborg
2014-07-19  9:11             ` Sam Ravnborg
2014-07-19 17:21             ` James Bottomley
2014-08-05  9:07             ` Geert Uytterhoeven
2014-08-05  9:14               ` Sam Ravnborg
2014-07-19  7:44   ` Arnd Bergmann
2014-07-19  8:53     ` Sam Ravnborg
2014-07-19  8:53       ` Sam Ravnborg
2014-07-19  9:10       ` Arnd Bergmann
2014-07-19 12:59   ` [PATCH] asm-generic/io.h: reorder funtions to form logical groups Sam Ravnborg
2014-08-01 14:09     ` Thierry Reding
2014-08-01 14:09       ` Thierry Reding
2014-08-01 22:42       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140719084152.GA31564@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sboyd@codeaurora.org \
    --cc=thierry.reding@gmail.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).