From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Klauser Subject: Re: [PATCH v3 26/29] nios2: ptrace support Date: Tue, 16 Sep 2014 11:43:21 +0200 Message-ID: <20140916094321.GA4610@distanz.ch> References: <1410168160-3624-1-git-send-email-lftan@altera.com> <1410168160-3624-27-git-send-email-lftan@altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1410168160-3624-27-git-send-email-lftan@altera.com> Sender: linux-doc-owner@vger.kernel.org To: Ley Foon Tan Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, lftan.linux@gmail.com, cltang@codesourcery.com List-Id: linux-arch.vger.kernel.org On 2014-09-08 at 11:22:37 +0200, Ley Foon Tan wrote: > Add ptrace support for nios2. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/ptrace.h | 33 +++++++ > arch/nios2/include/uapi/asm/ptrace.h | 120 ++++++++++++++++++++++++ > arch/nios2/kernel/ptrace.c | 176 +++++++++++++++++++++++++++++++++++ > 3 files changed, 329 insertions(+) > create mode 100644 arch/nios2/include/asm/ptrace.h > create mode 100644 arch/nios2/include/uapi/asm/ptrace.h > create mode 100644 arch/nios2/kernel/ptrace.c [...] > diff --git a/arch/nios2/kernel/ptrace.c b/arch/nios2/kernel/ptrace.c > new file mode 100644 > index 0000000..bcbf748 > --- /dev/null > +++ b/arch/nios2/kernel/ptrace.c [...] > +long arch_ptrace(struct task_struct *child, long request, unsigned long addr, > + unsigned long data) > +{ > + int ret = -EIO; > + > + pr_debug("REQ=%ld: ADDR =0x%lx, DATA=0x%lx)\n", request, addr, data); > + > + switch (request) { > + default: > + ret = ptrace_request(child, request, addr, data); > + break; > + } > + > + return ret; > +} This could be simplified to: long arch_ptrace(struct task_struct *child, long request, unsigned long addr, unsigned long data) { return ptrace_request(child, request, addr, data); } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sym2.noone.org ([178.63.92.236]:60262 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350AbaIPJn1 (ORCPT ); Tue, 16 Sep 2014 05:43:27 -0400 Date: Tue, 16 Sep 2014 11:43:21 +0200 From: Tobias Klauser Subject: Re: [PATCH v3 26/29] nios2: ptrace support Message-ID: <20140916094321.GA4610@distanz.ch> References: <1410168160-3624-1-git-send-email-lftan@altera.com> <1410168160-3624-27-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410168160-3624-27-git-send-email-lftan@altera.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ley Foon Tan Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, lftan.linux@gmail.com, cltang@codesourcery.com Message-ID: <20140916094321.fvoj6cxghGAiXu5CajV0A_2mFeJwYFJic-ebFozK454@z> On 2014-09-08 at 11:22:37 +0200, Ley Foon Tan wrote: > Add ptrace support for nios2. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/ptrace.h | 33 +++++++ > arch/nios2/include/uapi/asm/ptrace.h | 120 ++++++++++++++++++++++++ > arch/nios2/kernel/ptrace.c | 176 +++++++++++++++++++++++++++++++++++ > 3 files changed, 329 insertions(+) > create mode 100644 arch/nios2/include/asm/ptrace.h > create mode 100644 arch/nios2/include/uapi/asm/ptrace.h > create mode 100644 arch/nios2/kernel/ptrace.c [...] > diff --git a/arch/nios2/kernel/ptrace.c b/arch/nios2/kernel/ptrace.c > new file mode 100644 > index 0000000..bcbf748 > --- /dev/null > +++ b/arch/nios2/kernel/ptrace.c [...] > +long arch_ptrace(struct task_struct *child, long request, unsigned long addr, > + unsigned long data) > +{ > + int ret = -EIO; > + > + pr_debug("REQ=%ld: ADDR =0x%lx, DATA=0x%lx)\n", request, addr, data); > + > + switch (request) { > + default: > + ret = ptrace_request(child, request, addr, data); > + break; > + } > + > + return ret; > +} This could be simplified to: long arch_ptrace(struct task_struct *child, long request, unsigned long addr, unsigned long data) { return ptrace_request(child, request, addr, data); }