From: Bjorn Helgaas <bhelgaas@google.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Russell King <linux@arm.linux.org.uk>,
linux-pci <linux-pci@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Tanmay Inamdar <tinamdar@apm.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sinan Kaya <okaya@codeaurora.org>,
Jingoo Han <jg1.han@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
linux-arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Device Tree ML <devicetree@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
Grant Likely <grant.likely@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Simon Horman <horms@ver>
Subject: Re: [PATCH v11 04/10] PCI: OF: Fix the conversion of IO ranges into IO resources.
Date: Fri, 19 Sep 2014 14:56:13 -0600 [thread overview]
Message-ID: <20140919205613.GG19374@google.com> (raw)
In-Reply-To: <1411003825-21521-5-git-send-email-Liviu.Dudau@arm.com>
On Thu, Sep 18, 2014 at 02:30:19AM +0100, Liviu Dudau wrote:
> The ranges property for a host bridge controller in DT describes
> the mapping between the PCI bus address and the CPU physical address.
> The resources framework however expects that the IO resources start
> at a pseudo "port" address 0 (zero) and have a maximum size of IO_SPACE_LIMIT.
> The conversion from pci ranges to resources failed to take that into account.
>
> In the process move the function into drivers/of/address.c as it now
> depends on pci_address_to_pio() code and make it return an error code.
I think you're talking about of_pci_range_to_resource(). Can you split
this into one patch that moves it from of_address.h to of/address.c without
changing its functionality, and a second one that does the actual change?
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Russell King <linux@arm.linux.org.uk>,
linux-pci <linux-pci@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Tanmay Inamdar <tinamdar@apm.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sinan Kaya <okaya@codeaurora.org>,
Jingoo Han <jg1.han@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
linux-arch <linux-arch@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Device Tree ML <devicetree@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
Grant Likely <grant.likely@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v11 04/10] PCI: OF: Fix the conversion of IO ranges into IO resources.
Date: Fri, 19 Sep 2014 14:56:13 -0600 [thread overview]
Message-ID: <20140919205613.GG19374@google.com> (raw)
Message-ID: <20140919205613.80hIRqny0u9li7Hbjk2EerurdbYVhpUUlTV8UYElRM4@z> (raw)
In-Reply-To: <1411003825-21521-5-git-send-email-Liviu.Dudau@arm.com>
On Thu, Sep 18, 2014 at 02:30:19AM +0100, Liviu Dudau wrote:
> The ranges property for a host bridge controller in DT describes
> the mapping between the PCI bus address and the CPU physical address.
> The resources framework however expects that the IO resources start
> at a pseudo "port" address 0 (zero) and have a maximum size of IO_SPACE_LIMIT.
> The conversion from pci ranges to resources failed to take that into account.
>
> In the process move the function into drivers/of/address.c as it now
> depends on pci_address_to_pio() code and make it return an error code.
I think you're talking about of_pci_range_to_resource(). Can you split
this into one patch that moves it from of_address.h to of/address.c without
changing its functionality, and a second one that does the actual change?
Bjorn
next prev parent reply other threads:[~2014-09-19 20:56 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 1:30 [PATCH v11 00/10] Support for creating generic PCI host bridges from DT Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 01/10] Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 02/10] PCI: Introduce helper functions to deal with PCI I/O ranges Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
[not found] ` <1411003825-21521-3-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2014-09-19 20:48 ` Bjorn Helgaas
2014-09-19 20:48 ` Bjorn Helgaas
2014-09-18 1:30 ` [PATCH v11 03/10] ARM: Define PCI_IOBASE as the base of virtual PCI IO space Liviu Dudau
[not found] ` <1411003825-21521-4-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2014-09-20 2:14 ` Arnd Bergmann
2014-09-20 2:14 ` Arnd Bergmann
2014-09-18 1:30 ` [PATCH v11 04/10] PCI: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-19 20:56 ` Bjorn Helgaas [this message]
2014-09-19 20:56 ` Bjorn Helgaas
2014-09-20 17:33 ` Rob Herring
2014-09-22 15:32 ` Liviu Dudau
2014-09-22 15:32 ` Liviu Dudau
2014-09-22 17:18 ` Rob Herring
2014-09-22 17:18 ` Rob Herring
2014-09-18 1:30 ` [PATCH v11 05/10] PCI: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 06/10] PCI: Introduce generic domain handling for PCI busses Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 07/10] OF: Introduce helper function for getting PCI domain_nr Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-19 21:03 ` Bjorn Helgaas
2014-09-19 21:03 ` Bjorn Helgaas
2014-09-22 11:05 ` Liviu Dudau
2014-09-22 11:05 ` Liviu Dudau
2014-09-22 15:25 ` Bjorn Helgaas
2014-09-22 15:25 ` Bjorn Helgaas
2014-09-22 15:33 ` Liviu Dudau
2014-09-22 15:33 ` Liviu Dudau
2014-09-20 2:24 ` Arnd Bergmann
2014-09-20 2:24 ` Arnd Bergmann
2014-09-22 15:20 ` Liviu Dudau
2014-09-22 15:20 ` Liviu Dudau
2014-09-20 17:52 ` Rob Herring
2014-09-18 1:30 ` [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-19 21:06 ` Bjorn Helgaas
2014-09-19 21:06 ` Bjorn Helgaas
2014-09-20 0:28 ` Rob Herring
2014-09-22 17:55 ` Liviu Dudau
2014-09-22 17:55 ` Liviu Dudau
2014-09-22 22:11 ` Rob Herring
2014-09-22 9:32 ` Robert Richter
2014-09-22 9:32 ` Robert Richter
2014-09-22 11:43 ` Liviu Dudau
2014-09-22 11:43 ` Liviu Dudau
[not found] ` <20140922114317.GN1994-2JSQmVVBSi7ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-09-22 12:15 ` Robert Richter
2014-09-22 12:15 ` Robert Richter
2014-09-23 7:56 ` Arnd Bergmann
2014-09-23 7:56 ` Arnd Bergmann
2014-09-23 10:49 ` Liviu Dudau
2014-09-23 10:49 ` Liviu Dudau
2014-09-23 13:30 ` Rob Herring
2014-09-23 13:30 ` Rob Herring
2014-09-23 13:58 ` Liviu Dudau
2014-09-23 13:58 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 09/10] PCI: Assign unassigned bus resources in pci_scan_root_bus() Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-18 1:30 ` [PATCH v11 10/10] PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources into CPU space Liviu Dudau
2014-09-18 1:30 ` Liviu Dudau
2014-09-19 21:54 ` Bjorn Helgaas
2014-09-19 21:54 ` Bjorn Helgaas
2014-09-20 2:20 ` Arnd Bergmann
2014-09-20 2:20 ` Arnd Bergmann
2014-09-22 15:29 ` Robert Richter
2014-09-20 0:34 ` Rob Herring
2014-09-20 0:34 ` Rob Herring
2014-09-19 21:59 ` [PATCH v11 00/10] Support for creating generic PCI host bridges from DT Bjorn Helgaas
2014-09-19 21:59 ` Bjorn Helgaas
2014-09-22 11:35 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919205613.GG19374@google.com \
--to=bhelgaas@google.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=horms@ver \
--cc=jg1.han@samsung.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=okaya@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thierry.reding@gmail.com \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).