From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Date: Mon, 22 Sep 2014 14:15:47 +0200 Message-ID: <20140922121547.GD20170@rric.localhost> References: <1411003825-21521-1-git-send-email-Liviu.Dudau@arm.com> <1411003825-21521-9-git-send-email-Liviu.Dudau@arm.com> <20140922093228.GA20256@rric.localhost> <20140922114317.GN1994@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140922114317.GN1994-2JSQmVVBSi7ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liviu Dudau Cc: Bjorn Helgaas , Arnd Bergmann , Rob Herring , Jason Gunthorpe , Benjamin Herrenschmidt , Catalin Marinas , Will Deacon , Russell King , linux-pci , Linus Walleij , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , linux-arch , LKML , Device Tree ML , LAKML , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" Sunil Goutham List-Id: linux-arch.vger.kernel.org On 22.09.14 12:43:17, Liviu Dudau wrote: > On Mon, Sep 22, 2014 at 10:32:28AM +0100, Robert Richter wrote: > > On 18.09.14 02:30:23, Liviu Dudau wrote: > > > +int of_pci_get_host_bridge_resources(struct device_node *dev, > > > + unsigned char busno, unsigned char bus_max, > > > + struct list_head *resources, resource_size_t *io_base) > > > +{ > > > + struct resource *res; > > > + struct resource *bus_range; > > > + struct of_pci_range range; > > > + struct of_pci_range_parser parser; > > > + char range_type[4]; > > > + int err; > > > + > > > + if (!io_base) > > > + return -EINVAL; > > > + *io_base =3D OF_BAD_ADDR; > >=20 >=20 > Hi Robert, >=20 > > This breaks for mem-mapped pci host controllers. The patch below fi= xes > > this. >=20 > I think you mean PCI host controller that have only memory mapped ran= ges, > am I right? Initially I've read your reply as to mean that the host > controller is accessed through some memory mapped area, which I belie= ve is > the case for all host controllers. Right, that's meant here. Sorry for the misleading comment. >=20 > >=20 > > This series was tested with the fix on top for Cavium Thunder. > >=20 > > Tested-by: Robert Richter >=20 > Thanks for that! >=20 > >=20 > > -Robert > >=20 > >=20 > >=20 > > From e798af4fc2f664d1aff7e863489b8298f90e716e Mon Sep 17 00:00:00 2= 001 > > From: Robert Richter > > Date: Mon, 22 Sep 2014 10:46:01 +0200 > > Subject: [PATCH] OF: PCI: Fix creation of mem-mapped pci host bridg= es > >=20 > > The pci host bridge was not created if io_base was not set when > > calling of_pci_get_host_bridge_resources(). This is esp. the case f= or > > mem-mapped io (IORESOURCE_MEM). This patch fixes this. Function > > parameter io_base is optional now. >=20 > I think the message is misleading. What you want to do is make io_bas= e > optional for the case where the PCI host bridge only expects to have = only > IORESOURCE_MEM ranges and doesn't care about IORESOURCE_IO ones. >=20 > As I'm going to touch this area again to address a comment from Bjorn= , > do you mind if I roll this patch into mine with your Signed-off-by an= d > the mention that you have made io_base optional? Sure, fine with me. Thanks, -Robert >=20 > Best regards, > Liviu >=20 > >=20 > > Signed-off-by: Robert Richter > > --- > > drivers/of/of_pci.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > >=20 > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > > index ffdb45ed8682..1f0e7c2505ee 100644 > > --- a/drivers/of/of_pci.c > > +++ b/drivers/of/of_pci.c > > @@ -182,9 +182,8 @@ int of_pci_get_host_bridge_resources(struct dev= ice_node *dev, > > char range_type[4]; > > int err; > > =20 > > - if (!io_base) > > - return -EINVAL; > > - *io_base =3D OF_BAD_ADDR; > > + if (io_base) > > + *io_base =3D OF_BAD_ADDR; > > =20 > > bus_range =3D kzalloc(sizeof(*bus_range), GFP_KERNEL); > > if (!bus_range) > > @@ -242,7 +241,7 @@ int of_pci_get_host_bridge_resources(struct dev= ice_node *dev, > > goto parse_failed; > > } > > =20 > > - if (resource_type(res) =3D=3D IORESOURCE_IO) { > > + if (io_base && resource_type(res) =3D=3D IORESOURCE_IO) { > > if (*io_base !=3D OF_BAD_ADDR) > > pr_warn("More than one I/O resource converted. CPU offset for = old range lost!\n"); > > *io_base =3D range.cpu_addr; > > --=20 > > 2.1.0 > >=20 > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci= " in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >=20 >=20 > --=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > =C2=AF\_(=E3=83=84)_/=C2=AF >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com ([74.125.82.173]:54757 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753491AbaIVMPx (ORCPT ); Mon, 22 Sep 2014 08:15:53 -0400 Date: Mon, 22 Sep 2014 14:15:47 +0200 From: Robert Richter Subject: Re: [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Message-ID: <20140922121547.GD20170@rric.localhost> References: <1411003825-21521-1-git-send-email-Liviu.Dudau@arm.com> <1411003825-21521-9-git-send-email-Liviu.Dudau@arm.com> <20140922093228.GA20256@rric.localhost> <20140922114317.GN1994@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140922114317.GN1994@e106497-lin.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Liviu Dudau Cc: Bjorn Helgaas , Arnd Bergmann , Rob Herring , Jason Gunthorpe , Benjamin Herrenschmidt , Catalin Marinas , Will Deacon , Russell King , linux-pci , Linus Walleij , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , linux-arch , LKML , Device Tree ML , LAKML , "grant.likely@linaro.org" , Sunil Goutham Message-ID: <20140922121547.jlAnMqViBhf1gWI0Rtzo47cR9o5PZQBazCIpOW_yDHA@z> On 22.09.14 12:43:17, Liviu Dudau wrote: > On Mon, Sep 22, 2014 at 10:32:28AM +0100, Robert Richter wrote: > > On 18.09.14 02:30:23, Liviu Dudau wrote: > > > +int of_pci_get_host_bridge_resources(struct device_node *dev, > > > + unsigned char busno, unsigned char bus_max, > > > + struct list_head *resources, resource_size_t *io_base) > > > +{ > > > + struct resource *res; > > > + struct resource *bus_range; > > > + struct of_pci_range range; > > > + struct of_pci_range_parser parser; > > > + char range_type[4]; > > > + int err; > > > + > > > + if (!io_base) > > > + return -EINVAL; > > > + *io_base = OF_BAD_ADDR; > > > > Hi Robert, > > > This breaks for mem-mapped pci host controllers. The patch below fixes > > this. > > I think you mean PCI host controller that have only memory mapped ranges, > am I right? Initially I've read your reply as to mean that the host > controller is accessed through some memory mapped area, which I believe is > the case for all host controllers. Right, that's meant here. Sorry for the misleading comment. > > > > > This series was tested with the fix on top for Cavium Thunder. > > > > Tested-by: Robert Richter > > Thanks for that! > > > > > -Robert > > > > > > > > From e798af4fc2f664d1aff7e863489b8298f90e716e Mon Sep 17 00:00:00 2001 > > From: Robert Richter > > Date: Mon, 22 Sep 2014 10:46:01 +0200 > > Subject: [PATCH] OF: PCI: Fix creation of mem-mapped pci host bridges > > > > The pci host bridge was not created if io_base was not set when > > calling of_pci_get_host_bridge_resources(). This is esp. the case for > > mem-mapped io (IORESOURCE_MEM). This patch fixes this. Function > > parameter io_base is optional now. > > I think the message is misleading. What you want to do is make io_base > optional for the case where the PCI host bridge only expects to have only > IORESOURCE_MEM ranges and doesn't care about IORESOURCE_IO ones. > > As I'm going to touch this area again to address a comment from Bjorn, > do you mind if I roll this patch into mine with your Signed-off-by and > the mention that you have made io_base optional? Sure, fine with me. Thanks, -Robert > > Best regards, > Liviu > > > > > Signed-off-by: Robert Richter > > --- > > drivers/of/of_pci.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c > > index ffdb45ed8682..1f0e7c2505ee 100644 > > --- a/drivers/of/of_pci.c > > +++ b/drivers/of/of_pci.c > > @@ -182,9 +182,8 @@ int of_pci_get_host_bridge_resources(struct device_node *dev, > > char range_type[4]; > > int err; > > > > - if (!io_base) > > - return -EINVAL; > > - *io_base = OF_BAD_ADDR; > > + if (io_base) > > + *io_base = OF_BAD_ADDR; > > > > bus_range = kzalloc(sizeof(*bus_range), GFP_KERNEL); > > if (!bus_range) > > @@ -242,7 +241,7 @@ int of_pci_get_host_bridge_resources(struct device_node *dev, > > goto parse_failed; > > } > > > > - if (resource_type(res) == IORESOURCE_IO) { > > + if (io_base && resource_type(res) == IORESOURCE_IO) { > > if (*io_base != OF_BAD_ADDR) > > pr_warn("More than one I/O resource converted. CPU offset for old range lost!\n"); > > *io_base = range.cpu_addr; > > -- > > 2.1.0 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(ツ)_/¯ >