From: Steve Capper <steve.capper@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
linux@arm.linux.org.uk, linux-arch@vger.kernel.org,
linux-mm@kvack.org, will.deacon@arm.com,
gary.robertson@linaro.org, christoffer.dall@linaro.org,
peterz@infradead.org, anders.roxell@linaro.org,
akpm@linux-foundation.org, dann.frazier@canonical.com,
mark.rutland@arm.com, mgorman@suse.de, hughd@google.com
Subject: Re: [PATCH V4 1/6] mm: Introduce a general RCU get_user_pages_fast.
Date: Tue, 14 Oct 2014 13:38:34 +0100 [thread overview]
Message-ID: <20141014123834.GA1110@linaro.org> (raw)
In-Reply-To: <20141013.120618.1470323732942174784.davem@davemloft.net>
On Mon, Oct 13, 2014 at 12:06:18PM -0400, David Miller wrote:
> From: Steve Capper <steve.capper@linaro.org>
> Date: Mon, 13 Oct 2014 12:44:28 +0100
>
> > Also, as a heads up for Sparc. I don't see any definition of
> > __get_user_pages_fast. Does this mean that a futex on THP tail page
> > can cause an infinite loop?
>
> I have no idea, I didn't realize this was required to be implemented.
In get_futex_key, a call is made to __get_user_pages_fast to handle the
case where a THP tail page needs to be pinned for the futex. There is a
stock implementation of __get_user_pages_fast, but this is just an
empty function that returns 0. Unfortunately this will provoke a goto
to "again:" and end up in an infinite loop. The process will appear
to hang with a high system cpu usage.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Steve Capper <steve.capper@linaro.org>
To: David Miller <davem@davemloft.net>
Cc: aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
linux@arm.linux.org.uk, linux-arch@vger.kernel.org,
linux-mm@kvack.org, will.deacon@arm.com,
gary.robertson@linaro.org, christoffer.dall@linaro.org,
peterz@infradead.org, anders.roxell@linaro.org,
akpm@linux-foundation.org, dann.frazier@canonical.com,
mark.rutland@arm.com, mgorman@suse.de, hughd@google.com
Subject: Re: [PATCH V4 1/6] mm: Introduce a general RCU get_user_pages_fast.
Date: Tue, 14 Oct 2014 13:38:34 +0100 [thread overview]
Message-ID: <20141014123834.GA1110@linaro.org> (raw)
Message-ID: <20141014123834.-QJWjFLfQaS2ecehA173oQmwxI-RJpUrdNg8D9WScZk@z> (raw)
In-Reply-To: <20141013.120618.1470323732942174784.davem@davemloft.net>
On Mon, Oct 13, 2014 at 12:06:18PM -0400, David Miller wrote:
> From: Steve Capper <steve.capper@linaro.org>
> Date: Mon, 13 Oct 2014 12:44:28 +0100
>
> > Also, as a heads up for Sparc. I don't see any definition of
> > __get_user_pages_fast. Does this mean that a futex on THP tail page
> > can cause an infinite loop?
>
> I have no idea, I didn't realize this was required to be implemented.
In get_futex_key, a call is made to __get_user_pages_fast to handle the
case where a THP tail page needs to be pinned for the futex. There is a
stock implementation of __get_user_pages_fast, but this is just an
empty function that returns 0. Unfortunately this will provoke a goto
to "again:" and end up in an infinite loop. The process will appear
to hang with a high system cpu usage.
next prev parent reply other threads:[~2014-10-14 12:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:03 [PATCH V4 0/6] RCU get_user_pages_fast and __get_user_pages_fast Steve Capper
2014-09-26 14:03 ` Steve Capper
2014-09-26 14:03 ` [PATCH V4 1/6] mm: Introduce a general RCU get_user_pages_fast Steve Capper
2014-09-26 14:03 ` Steve Capper
2014-09-29 21:51 ` Hugh Dickins
2014-09-29 21:51 ` Hugh Dickins
2014-10-01 11:11 ` Catalin Marinas
2014-10-01 11:11 ` Catalin Marinas
2014-10-02 16:00 ` Steve Capper
2014-10-02 16:00 ` Steve Capper
2014-10-02 12:19 ` Andrea Arcangeli
2014-10-02 12:19 ` Andrea Arcangeli
2014-10-02 16:18 ` Steve Capper
2014-10-02 16:18 ` Steve Capper
2014-10-02 16:54 ` Andrea Arcangeli
2014-10-02 16:54 ` Andrea Arcangeli
2014-10-13 5:15 ` Aneesh Kumar K.V
2014-10-13 5:21 ` David Miller
2014-10-13 5:21 ` David Miller
2014-10-13 11:44 ` Steve Capper
2014-10-13 11:44 ` Steve Capper
2014-10-13 16:06 ` David Miller
2014-10-14 12:38 ` Steve Capper [this message]
2014-10-14 12:38 ` Steve Capper
2014-10-14 16:30 ` David Miller
2014-10-14 16:30 ` David Miller
2014-10-13 17:04 ` Aneesh Kumar K.V
2014-10-13 6:22 ` Aneesh Kumar K.V
2014-10-13 6:22 ` Aneesh Kumar K.V
2014-09-26 14:03 ` [PATCH V4 2/6] arm: mm: Introduce special ptes for LPAE Steve Capper
2014-09-26 14:03 ` Steve Capper
2014-09-26 14:03 ` [PATCH V4 3/6] arm: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper
2014-09-26 14:03 ` Steve Capper
2014-09-26 14:03 ` [PATCH V4 4/6] arm: mm: Enable RCU fast_gup Steve Capper
2014-09-26 14:03 ` Steve Capper
2014-09-26 14:03 ` [PATCH V4 5/6] arm64: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper
2014-09-26 14:03 ` [PATCH V4 6/6] arm64: mm: Enable RCU fast_gup Steve Capper
2015-02-27 12:42 ` [PATCH V4 0/6] RCU get_user_pages_fast and __get_user_pages_fast Jon Masters
2015-02-27 12:42 ` Jon Masters
2015-02-27 13:20 ` Mark Rutland
2015-03-02 14:16 ` Mark Rutland
2015-03-02 2:10 ` PMD update corruption (sync question) Jon Masters
2015-03-02 2:10 ` Jon Masters
2015-03-02 5:58 ` Jon Masters
2015-03-02 5:58 ` Jon Masters
2015-03-02 10:50 ` Catalin Marinas
2015-03-02 11:06 ` Jon Masters
2015-03-02 11:06 ` Jon Masters
2015-03-02 12:31 ` Peter Zijlstra
2015-03-02 12:31 ` Peter Zijlstra
2015-03-02 12:40 ` Geert Uytterhoeven
2015-03-02 12:40 ` Geert Uytterhoeven
2015-03-02 22:21 ` Jon Masters
2015-03-02 22:21 ` Jon Masters
2015-03-02 22:29 ` Jon Masters
2015-03-02 22:29 ` Jon Masters
2015-03-03 9:06 ` Arnd Bergmann
2015-03-03 15:46 ` Jon Masters
2015-03-03 15:46 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014123834.GA1110@linaro.org \
--to=steve.capper@linaro.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dann.frazier@canonical.com \
--cc=davem@davemloft.net \
--cc=gary.robertson@linaro.org \
--cc=hughd@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).