From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
linux-arch <linux-arch@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
hpa@zytor.com
Subject: Re: [PATCH] all arches, signal: Move restart_block to struct task_struct
Date: Sun, 26 Oct 2014 17:18:19 +0000 [thread overview]
Message-ID: <20141026171819.GQ7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <90d5683679179df27ffeef18c3e1010ed4e72695.1414342681.git.luto@amacapital.net>
On Sun, Oct 26, 2014 at 10:02:16AM -0700, Andy Lutomirski wrote:
> If an attacker can cause a controlled kernel stack overflow,
> overwriting the restart block is a very juicy exploit target.
> Moving the restart block to struct task_struct prevents this type of
> exploit.
The hell it does. In a _lot_ of cases current is current_thread_info()->task,
which makes your variant just as vulnerable, in addition to being (slightly)
more costly.
next prev parent reply other threads:[~2014-10-26 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:02 [PATCH] all arches, signal: Move restart_block to struct task_struct Andy Lutomirski
2014-10-26 17:02 ` Andy Lutomirski
2014-10-26 17:18 ` Al Viro [this message]
2014-10-26 17:36 ` Andy Lutomirski
2014-10-26 17:36 ` Andy Lutomirski
2014-10-26 18:09 ` Al Viro
2014-10-26 18:11 ` H. Peter Anvin
2014-10-27 1:08 ` Andy Lutomirski
2014-10-26 18:38 ` Sam Ravnborg
2014-10-26 18:38 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141026171819.GQ7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox