From: Sam Ravnborg <sam@ravnborg.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
linux-arch <linux-arch@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
hpa@zytor.com
Subject: Re: [PATCH] all arches, signal: Move restart_block to struct task_struct
Date: Sun, 26 Oct 2014 19:38:27 +0100 [thread overview]
Message-ID: <20141026183826.GA18348@ravnborg.org> (raw)
In-Reply-To: <90d5683679179df27ffeef18c3e1010ed4e72695.1414342681.git.luto@amacapital.net>
sparc/include/asm/thread_info_32.h b/arch/sparc/include/asm/thread_info_32.h
> index 025c98446b1e..88719dbb12f5 100644
> --- a/arch/sparc/include/asm/thread_info_32.h
> +++ b/arch/sparc/include/asm/thread_info_32.h
> @@ -62,9 +62,6 @@ struct thread_info {
> .flags = 0, \
> .cpu = 0, \
> .preempt_count = INIT_PREEMPT_COUNT, \
> - .restart_block = { \
> - .fn = do_no_restart_syscall, \
> - }, \
> }
If this is deleted then the corresponding TI_RESTART_BLOCK should go as well
>
> #define init_thread_info (init_thread_union.thread_info)
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> index 798f0279a4b5..a11f1e551a58 100644
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -124,9 +124,6 @@ struct thread_info {
> .current_ds = ASI_P, \
> .exec_domain = &default_exec_domain, \
> .preempt_count = INIT_PREEMPT_COUNT, \
> - .restart_block = { \
> - .fn = do_no_restart_syscall, \
> - }, \
> }
When thread_info is modified the relevant TI_ constants needs to be updated.
And TI_RESTART_BLOCK shold be killed as it is no longer relevant.
This stuff is caught only at run-time - and not at build time which would
have been better.
Sam
next prev parent reply other threads:[~2014-10-26 18:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:02 [PATCH] all arches, signal: Move restart_block to struct task_struct Andy Lutomirski
2014-10-26 17:02 ` Andy Lutomirski
2014-10-26 17:18 ` Al Viro
2014-10-26 17:36 ` Andy Lutomirski
2014-10-26 17:36 ` Andy Lutomirski
2014-10-26 18:09 ` Al Viro
2014-10-26 18:11 ` H. Peter Anvin
2014-10-27 1:08 ` Andy Lutomirski
2014-10-26 18:38 ` Sam Ravnborg [this message]
2014-10-26 18:38 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141026183826.GA18348@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox