Re: [PATCH] all arches, signal: Move restart_block to struct task_struct

Sam Ravnborg
2014-10-26T18:38:27Z

sparc/include/asm/thread_info_32.h b/arch/sparc/include/asm/thread_info_32.h
> index 025c98446b1e..88719dbb12f5 100644
> --- a/arch/sparc/include/asm/thread_info_32.h
> +++ b/arch/sparc/include/asm/thread_info_32.h
> @@ -62,9 +62,6 @@ struct thread_info {
> .flags = 0, \
> .cpu = 0, \
> .preempt_count = INIT_PREEMPT_COUNT, \
> - .restart_block = { \
> - .fn = do_no_restart_syscall, \
> - }, \
> }
If this is deleted then the corresponding TI_RESTART_BLOCK should go as well

>
> #define init_thread_info (init_thread_union.thread_info)
> diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h
> index 798f0279a4b5..a11f1e551a58 100644
> --- a/arch/sparc/include/asm/thread_info_64.h
> +++ b/arch/sparc/include/asm/thread_info_64.h
> @@ -124,9 +124,6 @@ struct thread_info {
> .current_ds = ASI_P, \
> .exec_domain = &default_exec_domain, \
> .preempt_count = INIT_PREEMPT_COUNT, \
> - .restart_block = { \
> - .fn = do_no_restart_syscall, \
> - }, \
> }
When thread_info is modified the relevant TI_ constants needs to be updated.
And TI_RESTART_BLOCK shold be killed as it is no longer relevant.

This stuff is caught only at run-time - and not at build time which would
have been better.

Sam