From: Will Deacon <will.deacon@arm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Christopher Covington <cov@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/18] arm64/uaccess: fix sparse errors
Date: Mon, 15 Dec 2014 11:17:16 +0000 [thread overview]
Message-ID: <20141215111716.GG20738@arm.com> (raw)
In-Reply-To: <1418575877-21488-4-git-send-email-mst@redhat.com>
On Sun, Dec 14, 2014 at 04:52:09PM +0000, Michael S. Tsirkin wrote:
> virtio wants to read bitwise types from userspace using get_user. At the
> moment this triggers sparse errors, since the value is passed through an
> integer.
>
> Fix that up using __force.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/arm64/include/asm/uaccess.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> index 3bf8f4e..8d66bcf 100644
> --- a/arch/arm64/include/asm/uaccess.h
> +++ b/arch/arm64/include/asm/uaccess.h
> @@ -147,7 +147,7 @@ do { \
> default: \
> BUILD_BUG(); \
> } \
> - (x) = (__typeof__(*(ptr)))__gu_val; \
> + (x) = (__force __typeof__(*(ptr)))__gu_val; \
> } while (0)
>
> #define __get_user(x, ptr) \
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2014-12-15 11:17 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 16:51 [PATCH 00/18] uaccess: fix sparse warning on get_user for bitwise types Michael S. Tsirkin
2014-12-14 16:51 ` [PATCH 01/18] x86/uaccess: fix sparse errors Michael S. Tsirkin
2014-12-14 16:51 ` Michael S. Tsirkin
2014-12-16 16:47 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 02/18] alpha/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 03/18] arm64/uaccess: " Michael S. Tsirkin
2014-12-15 11:17 ` Will Deacon [this message]
2014-12-15 11:23 ` Russell King - ARM Linux
2014-12-15 11:29 ` Michael S. Tsirkin
2014-12-15 12:54 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 04/18] avr32/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 20:35 ` Hans-Christian Egtvedt
2014-12-14 16:52 ` [PATCH 05/18] blackfin/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-18 3:11 ` Steven Miao
2014-12-14 16:52 ` [PATCH 06/18] cris/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 07/18] ia64/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 08/18] m32r/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 09/18] metag/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 10/18] microblaze/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 11/18] openrisc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 12/18] parisc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 13/18] powerpc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-15 0:05 ` Benjamin Herrenschmidt
2014-12-15 1:37 ` Benjamin Herrenschmidt
2014-12-16 16:47 ` Michael S. Tsirkin
2014-12-16 23:50 ` Michael Ellerman
2014-12-17 0:52 ` Benjamin Herrenschmidt
2014-12-17 10:53 ` Arnd Bergmann
2014-12-17 11:05 ` Benjamin Herrenschmidt
2014-12-14 16:52 ` [PATCH 14/18] sh/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:52 ` [PATCH 15/18] sparc/uaccess: " Michael S. Tsirkin
2014-12-14 16:52 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 16/18] " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 17/18] xtensa/uaccess: " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-14 16:53 ` [PATCH 18/18] m68k/uaccess: " Michael S. Tsirkin
2014-12-14 16:53 ` Michael S. Tsirkin
2014-12-15 0:40 ` [PATCH 00/18] uaccess: fix sparse warning on get_user for bitwise types Michael Ellerman
2014-12-15 10:22 ` Michael S. Tsirkin
2014-12-15 10:22 ` Michael S. Tsirkin
2014-12-16 23:49 ` Michael Ellerman
2014-12-15 10:03 ` LF.Tan
2014-12-15 10:17 ` Michael S. Tsirkin
2014-12-16 6:06 ` Ley Foon Tan
2014-12-16 6:57 ` Michael S. Tsirkin
2014-12-16 16:45 ` Michael S. Tsirkin
2014-12-18 6:54 ` Ley Foon Tan
2014-12-18 6:54 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215111716.GG20738@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).