Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

Pavel Machek
2014-12-28T18:36:28Z

On Fri 2014-12-19 10:33:42, Måns Rullgård wrote:
> Joe Perches <joe@perches.com> writes:
>
> > On Fri, 2014-12-19 at 01:43 +0000, Måns Rullgård wrote:
> >> What exactly are you proposing to remove?
> >
> > Optionally compile out
> > kernel/printk/printk.c:early_printk()
> > even if CONFIG_EARLY_PRINTK is enabled.
> >
> >> I see no unused code related
> >> to early printk (in any variant) under arch/mips.
> >
> > I think there could be yet another CONFIG option
> > to specifically enable the early_printk function
> > for the arches that use it.
>
> Why bother? On MIPS it would save 132 bytes of compiled code.
>
> > The kernel/printk/early_printk() function seems
> > used only by arm/microblaze/tile/x86.
>
> Rather than introduce more config complexity, you could try to remove
> the 7 remaining uses of early_printk().
>
> - arch/arm/mach-socfpga
> Single early_printk("Early printk initialized\n") call serving no
> apparent purpose can probably be safely deleted. Since there are no
> other early_printk() calls, this information seems rather useless.

Feel free to do that, but please keep early_printk() available...

...so that I can debug the socfpga early boot when needed.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html