From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 38/40] s390: macro whitespace fixes Date: Wed, 7 Jan 2015 11:07:31 +0200 Message-ID: <20150107090731.GB24298@redhat.com> References: <1420558883-10131-1-git-send-email-mst@redhat.com> <1420558883-10131-39-git-send-email-mst@redhat.com> <20150107083339.GB4365@osiris> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbbAGJHo (ORCPT ); Wed, 7 Jan 2015 04:07:44 -0500 Content-Disposition: inline In-Reply-To: <20150107083339.GB4365@osiris> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Heiko Carstens Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , linux-arch@vger.kernel.org, Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org On Wed, Jan 07, 2015 at 09:33:39AM +0100, Heiko Carstens wrote: > On Tue, Jan 06, 2015 at 05:45:38PM +0200, Michael S. Tsirkin wrote: > > While working on arch/s390/include/asm/uaccess.h, I noticed > > that a couple of macros within this header are made harder to read > > because they violate a coding style rule: space is missing after comma. > > > > Fix it up. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > arch/s390/include/asm/uaccess.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/s390/include/asm/uaccess.h b/arch/s390/include/asm/uaccess.h > > index cd4c68e..71b9c40 100644 > > --- a/arch/s390/include/asm/uaccess.h > > +++ b/arch/s390/include/asm/uaccess.h > > @@ -46,7 +46,7 @@ > > __ctl_load(__pto, 7, 7); \ > > }) > > > > -#define segment_eq(a,b) ((a).ar4 == (b).ar4) > > +#define segment_eq(a, b) ((a).ar4 == (b).ar4) > > > > static inline int __range_ok(unsigned long addr, unsigned long size) > > { > > @@ -147,7 +147,7 @@ unsigned long __must_check __copy_to_user(void __user *to, const void *from, > > "3: lhi %0,%5\n" \ > > " jg 2b\n" \ > > ".popsection\n" \ > > - EX_TABLE(0b,3b) EX_TABLE(1b,3b) \ > > + EX_TABLE(0b, 3b) EX_TABLE(1b, 3b) \ > > Most EX_TABLE() usages within s390 are without space after comma. > No need to change that. Also I don't like the change of the seqment_eq() > macro. > I won't apply trivial whitespace patches, since this would make 'git blame' > useless and in addition invite more people to send whitespace patches. > > Thanks, > Heiko There's always git blame -w. Anyway, I'll drop s390 patches. Fix it up yourself if you wish. -- MST