From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 05/14] ARM: call reset_controller_of_init from default time_init handler Date: Sun, 15 Feb 2015 23:12:51 +0000 Message-ID: <20150215231251.GL8656@n2100.arm.linux.org.uk> References: <1423763164-5606-1-git-send-email-mcoquelin.stm32@gmail.com> <1423763164-5606-6-git-send-email-mcoquelin.stm32@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Rob Herring Cc: Maxime Coquelin , Jonathan Corbet , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell List-Id: linux-arch.vger.kernel.org On Sun, Feb 15, 2015 at 04:17:31PM -0600, Rob Herring wrote: > On Thu, Feb 12, 2015 at 11:45 AM, Maxime Coquelin > wrote: > > Some DT ARM platforms need the reset controllers to be initialized before > > the timers. > > This is the case of the stm32 and sunxi platforms. > > I would say this is the exception, not the rule and therefore should > be handled in a machine desc function. Or it could be part of your > timer setup. Or is the bootloader's problem (like arch timer setup). > > We just want to limit how much this mechanism gets used. Can you clarify please - what is "this mechanism"? Placing explicit calls at this location, or the whole OF_DECLARE_* stuff? Sebastian suggested using the OF_DECLARE_* stuff for the Dove PMU - so maybe you have a comment on that too? Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:43384 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbbBOXOJ (ORCPT ); Sun, 15 Feb 2015 18:14:09 -0500 Date: Sun, 15 Feb 2015 23:12:51 +0000 From: Russell King - ARM Linux Subject: Re: [PATCH 05/14] ARM: call reset_controller_of_init from default time_init handler Message-ID: <20150215231251.GL8656@n2100.arm.linux.org.uk> References: <1423763164-5606-1-git-send-email-mcoquelin.stm32@gmail.com> <1423763164-5606-6-git-send-email-mcoquelin.stm32@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring Cc: Maxime Coquelin , Jonathan Corbet , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-api@vger.kernel.org" Message-ID: <20150215231251.5kE2g3LyV_oLs6Sm4bGkZ22ZqVv62140VHqAN49l7fg@z> On Sun, Feb 15, 2015 at 04:17:31PM -0600, Rob Herring wrote: > On Thu, Feb 12, 2015 at 11:45 AM, Maxime Coquelin > wrote: > > Some DT ARM platforms need the reset controllers to be initialized before > > the timers. > > This is the case of the stm32 and sunxi platforms. > > I would say this is the exception, not the rule and therefore should > be handled in a machine desc function. Or it could be part of your > timer setup. Or is the bootloader's problem (like arch timer setup). > > We just want to limit how much this mechanism gets used. Can you clarify please - what is "this mechanism"? Placing explicit calls at this location, or the whole OF_DECLARE_* stuff? Sebastian suggested using the OF_DECLARE_* stuff for the Dove PMU - so maybe you have a comment on that too? Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.