From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Epler Subject: Re: [PATCH] xtensa: Fix execdomain removal Date: Sun, 12 Apr 2015 09:43:46 -0500 Message-ID: <20150412144346.GD7215@unpythonic.net> References: <1428805191-27089-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1428805191-27089-1-git-send-email-linux@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org To: Guenter Roeck Cc: Richard Weinberger , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote: > The removal of exexdomain changes pointer offsets into the thread_info > structure. ... > -#define TI_EXEC_DOMAIN 0x00000004 > -#define TI_FLAGS 0x00000008 > +#define TI_FLAGS 0x00000004 Hmm. If these have to be maintained by hand, perhaps they can be BUILD_BUG_ON'd in some appropriate C file? e.g., BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags)); Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeroeth.unpythonic.net ([162.243.242.154]:35714 "EHLO zeroeth.unpythonic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbbDLPA7 (ORCPT ); Sun, 12 Apr 2015 11:00:59 -0400 Date: Sun, 12 Apr 2015 09:43:46 -0500 From: Jeff Epler Subject: Re: [PATCH] xtensa: Fix execdomain removal Message-ID: <20150412144346.GD7215@unpythonic.net> References: <1428805191-27089-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428805191-27089-1-git-send-email-linux@roeck-us.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guenter Roeck Cc: Richard Weinberger , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150412144346.Ql1gSwiHp18QOucFu-CB8nrxPi3F6IlxAa2c8vLY4f8@z> On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote: > The removal of exexdomain changes pointer offsets into the thread_info > structure. ... > -#define TI_EXEC_DOMAIN 0x00000004 > -#define TI_FLAGS 0x00000008 > +#define TI_FLAGS 0x00000004 Hmm. If these have to be maintained by hand, perhaps they can be BUILD_BUG_ON'd in some appropriate C file? e.g., BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags)); Jeff