* [PATCH] xtensa: Fix execdomain removal
@ 2015-04-12 2:19 Guenter Roeck
2015-04-12 14:43 ` Jeff Epler
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2015-04-12 2:19 UTC (permalink / raw)
To: Richard Weinberger
Cc: Chris Zankel, Max Filippov, linux-xtensa, linux-arch,
linux-kernel, Guenter Roeck
The removal of exexdomain changes pointer offsets into the thread_info
structure.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Applies on top of Richard's execdomain removal patches.
Tested with xtensa qemu session.
arch/xtensa/include/asm/thread_info.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/xtensa/include/asm/thread_info.h b/arch/xtensa/include/asm/thread_info.h
index d120278073b5..b3680a4738cd 100644
--- a/arch/xtensa/include/asm/thread_info.h
+++ b/arch/xtensa/include/asm/thread_info.h
@@ -64,12 +64,11 @@ struct thread_info {
/* offsets into the thread_info struct for assembly code access */
#define TI_TASK 0x00000000
-#define TI_EXEC_DOMAIN 0x00000004
-#define TI_FLAGS 0x00000008
-#define TI_STATUS 0x0000000C
-#define TI_CPU 0x00000010
-#define TI_PRE_COUNT 0x00000014
-#define TI_ADDR_LIMIT 0x00000018
+#define TI_FLAGS 0x00000004
+#define TI_STATUS 0x00000008
+#define TI_CPU 0x0000000C
+#define TI_PRE_COUNT 0x00000010
+#define TI_ADDR_LIMIT 0x00000014
#endif
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xtensa: Fix execdomain removal
2015-04-12 2:19 [PATCH] xtensa: Fix execdomain removal Guenter Roeck
@ 2015-04-12 14:43 ` Jeff Epler
2015-04-12 14:43 ` Jeff Epler
2015-04-12 15:00 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Epler @ 2015-04-12 14:43 UTC (permalink / raw)
To: Guenter Roeck
Cc: Richard Weinberger, Chris Zankel, Max Filippov, linux-xtensa,
linux-arch, linux-kernel
On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
> The removal of exexdomain changes pointer offsets into the thread_info
> structure.
...
> -#define TI_EXEC_DOMAIN 0x00000004
> -#define TI_FLAGS 0x00000008
> +#define TI_FLAGS 0x00000004
Hmm. If these have to be maintained by hand, perhaps they can be
BUILD_BUG_ON'd in some appropriate C file? e.g.,
BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xtensa: Fix execdomain removal
2015-04-12 14:43 ` Jeff Epler
@ 2015-04-12 14:43 ` Jeff Epler
2015-04-12 15:00 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Epler @ 2015-04-12 14:43 UTC (permalink / raw)
To: Guenter Roeck
Cc: Richard Weinberger, Chris Zankel, Max Filippov, linux-xtensa,
linux-arch, linux-kernel
On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
> The removal of exexdomain changes pointer offsets into the thread_info
> structure.
...
> -#define TI_EXEC_DOMAIN 0x00000004
> -#define TI_FLAGS 0x00000008
> +#define TI_FLAGS 0x00000004
Hmm. If these have to be maintained by hand, perhaps they can be
BUILD_BUG_ON'd in some appropriate C file? e.g.,
BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xtensa: Fix execdomain removal
2015-04-12 14:43 ` Jeff Epler
2015-04-12 14:43 ` Jeff Epler
@ 2015-04-12 15:00 ` Guenter Roeck
2015-04-12 15:00 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2015-04-12 15:00 UTC (permalink / raw)
To: Jeff Epler
Cc: Richard Weinberger, Chris Zankel, Max Filippov, linux-xtensa,
linux-arch, linux-kernel
On 04/12/2015 07:43 AM, Jeff Epler wrote:
> On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
>> The removal of exexdomain changes pointer offsets into the thread_info
>> structure.
> ...
>> -#define TI_EXEC_DOMAIN 0x00000004
>> -#define TI_FLAGS 0x00000008
>> +#define TI_FLAGS 0x00000004
>
> Hmm. If these have to be maintained by hand, perhaps they can be
> BUILD_BUG_ON'd in some appropriate C file? e.g.,
>
> BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
>
> Jeff
>
Other architectures use either DEFINE or OFFSET macros to define
those flags, so that would probably be a better solution if something
more fancy is asked for. That should probably be a separate patch,
though.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xtensa: Fix execdomain removal
2015-04-12 15:00 ` Guenter Roeck
@ 2015-04-12 15:00 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2015-04-12 15:00 UTC (permalink / raw)
To: Jeff Epler
Cc: Richard Weinberger, Chris Zankel, Max Filippov, linux-xtensa,
linux-arch, linux-kernel
On 04/12/2015 07:43 AM, Jeff Epler wrote:
> On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
>> The removal of exexdomain changes pointer offsets into the thread_info
>> structure.
> ...
>> -#define TI_EXEC_DOMAIN 0x00000004
>> -#define TI_FLAGS 0x00000008
>> +#define TI_FLAGS 0x00000004
>
> Hmm. If these have to be maintained by hand, perhaps they can be
> BUILD_BUG_ON'd in some appropriate C file? e.g.,
>
> BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
>
> Jeff
>
Other architectures use either DEFINE or OFFSET macros to define
those flags, so that would probably be a better solution if something
more fancy is asked for. That should probably be a separate patch,
though.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xtensa: Fix execdomain removal
@ 2015-04-12 14:58 Richard Weinberger
0 siblings, 0 replies; 6+ messages in thread
From: Richard Weinberger @ 2015-04-12 14:58 UTC (permalink / raw)
To: Jeff Epler
Cc: Guenter Roeck, Chris Zankel, Max Filippov, linux-xtensa,
linux-arch, linux-kernel
Jeff,
I'll add them to asm-offsets.c as I did for m32r and blackfin.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-26 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-12 2:19 [PATCH] xtensa: Fix execdomain removal Guenter Roeck
2015-04-12 14:43 ` Jeff Epler
2015-04-12 14:43 ` Jeff Epler
2015-04-12 15:00 ` Guenter Roeck
2015-04-12 15:00 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2015-04-12 14:58 Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox