From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures Date: Mon, 13 Jul 2015 13:23:03 +1000 (AEST) Message-ID: <20150713032303.D49801402B1@ozlabs.org> References: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> Return-path: In-Reply-To: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> Sender: linux-m68k-owner@vger.kernel.org To: Bjorn Helgaas , Thomas Gleixner Cc: linux-arch@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On Sun, 2015-12-07 at 22:02:11 UTC, Bjorn Helgaas wrote: > Many architectures use a variant of "unexpected IRQ trap at vector %x" to > log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ > number, but "vector" more often refers to a CPU vector number, and (b) it > prints the IRQ number in hex with no base indication, while Linux IRQ > numbers are usually printed in decimal. > > Print the same text ("unexpected IRQ %d") across all architectures. > > No functional change other than the output text. There's already a fallback version in asm-generic, so shouldn't you instead just delete all the versions that are identical to that? eg. on powerpc we have: > static inline void ack_bad_irq(unsigned int irq) > { > - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); > + printk(KERN_CRIT "unexpected IRQ %d\n", irq); > } And the generic version is: > #ifndef ack_bad_irq > static inline void ack_bad_irq(unsigned int irq) > { > - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); > + printk(KERN_CRIT "unexpected IRQ %d\n", irq); > } > #endif So we can just delete the powerpc version? cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:45022 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbbGMDXH (ORCPT ); Sun, 12 Jul 2015 23:23:07 -0400 In-Reply-To: <20150712220211.7166.42035.stgit@bhelgaas-glaptop2.roam.corp.google.com> From: Michael Ellerman Subject: Re: [3/3] IRQ: Print "unexpected IRQ" messages consistently across architectures Message-ID: <20150713032303.D49801402B1@ozlabs.org> Date: Mon, 13 Jul 2015 13:23:03 +1000 (AEST) Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bjorn Helgaas , Thomas Gleixner Cc: linux-arch@vger.kernel.org, linux-mips@linux-mips.org, linux-am33-list@redhat.com, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org Message-ID: <20150713032303.WfTEmQh0az1X1qkGyv-NrJ0d47RgMIRNCOGN8pxwRI8@z> On Sun, 2015-12-07 at 22:02:11 UTC, Bjorn Helgaas wrote: > Many architectures use a variant of "unexpected IRQ trap at vector %x" to > log unexpected IRQs. This is confusing because (a) it prints the Linux IRQ > number, but "vector" more often refers to a CPU vector number, and (b) it > prints the IRQ number in hex with no base indication, while Linux IRQ > numbers are usually printed in decimal. > > Print the same text ("unexpected IRQ %d") across all architectures. > > No functional change other than the output text. There's already a fallback version in asm-generic, so shouldn't you instead just delete all the versions that are identical to that? eg. on powerpc we have: > static inline void ack_bad_irq(unsigned int irq) > { > - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); > + printk(KERN_CRIT "unexpected IRQ %d\n", irq); > } And the generic version is: > #ifndef ack_bad_irq > static inline void ack_bad_irq(unsigned int irq) > { > - printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); > + printk(KERN_CRIT "unexpected IRQ %d\n", irq); > } > #endif So we can just delete the powerpc version? cheers