public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: rth@twiddle.net, vgupta@synopsys.com, linux@arm.linux.org.uk,
	will.deacon@arm.com, hskinnemoen@gmail.com, realmz6@gmail.com,
	dhowells@redhat.com, rkuo@codeaurora.org, tony.luck@intel.com,
	geert@linux-m68k.org, james.hogan@imgtec.com,
	ralf@linux-mips.org, jejb@parisc-linux.org,
	benh@kernel.crashing.org, heiko.carstens@de.ibm.com,
	davem@davemloft.net, cmetcalf@ezchip.com,
	ysato@users.sourceforge.jp, mingo@kernel.org,
	peterz@infradead.org
Subject: [PATCH 12/28] metag: Provide atomic_{or,xor,and}
Date: Thu, 16 Jul 2015 19:21:22 +0200	[thread overview]
Message-ID: <20150716172925.241515353@infradead.org> (raw)
In-Reply-To: 20150716172110.587529075@infradead.org

[-- Attachment #1: peterz-metag-atomic_logic_ops.patch --]
[-- Type: text/plain, Size: 2706 bytes --]

Implement atomic logic ops -- atomic_{or,xor,and}.

These will replace the atomic_{set,clear}_mask functions that are
available on some archs.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/metag/include/asm/atomic_lnkget.h |   38 ++++++++-------------------------
 arch/metag/include/asm/atomic_lock1.h  |   21 ++++++------------
 2 files changed, 17 insertions(+), 42 deletions(-)

--- a/arch/metag/include/asm/atomic_lnkget.h
+++ b/arch/metag/include/asm/atomic_lnkget.h
@@ -74,42 +74,24 @@ static inline int atomic_##op##_return(i
 ATOMIC_OPS(add)
 ATOMIC_OPS(sub)
 
+#define CONFIG_ARCH_HAS_ATOMIC_OR
+
+ATOMIC_OP(and)
+ATOMIC_OP(or)
+ATOMIC_OP(xor)
+
 #undef ATOMIC_OPS
 #undef ATOMIC_OP_RETURN
 #undef ATOMIC_OP
 
-static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
+static inline __deprecated void atomic_clear_mask(unsigned int mask, atomic_t *v)
 {
-	int temp;
-
-	asm volatile (
-		"1:	LNKGETD %0, [%1]\n"
-		"	AND	%0, %0, %2\n"
-		"	LNKSETD	[%1] %0\n"
-		"	DEFR	%0, TXSTAT\n"
-		"	ANDT	%0, %0, #HI(0x3f000000)\n"
-		"	CMPT	%0, #HI(0x02000000)\n"
-		"	BNZ	1b\n"
-		: "=&d" (temp)
-		: "da" (&v->counter), "bd" (~mask)
-		: "cc");
+	atomic_and(~mask, v);
 }
 
-static inline void atomic_set_mask(unsigned int mask, atomic_t *v)
+static inline __deprecated void atomic_set_mask(unsigned int mask, atomic_t *v)
 {
-	int temp;
-
-	asm volatile (
-		"1:	LNKGETD %0, [%1]\n"
-		"	OR	%0, %0, %2\n"
-		"	LNKSETD	[%1], %0\n"
-		"	DEFR	%0, TXSTAT\n"
-		"	ANDT	%0, %0, #HI(0x3f000000)\n"
-		"	CMPT	%0, #HI(0x02000000)\n"
-		"	BNZ	1b\n"
-		: "=&d" (temp)
-		: "da" (&v->counter), "bd" (mask)
-		: "cc");
+	atomic_or(mask, v);
 }
 
 static inline int atomic_cmpxchg(atomic_t *v, int old, int new)
--- a/arch/metag/include/asm/atomic_lock1.h
+++ b/arch/metag/include/asm/atomic_lock1.h
@@ -68,29 +68,22 @@ static inline int atomic_##op##_return(i
 
 ATOMIC_OPS(add, +=)
 ATOMIC_OPS(sub, -=)
+ATOMIC_OP(and, &=)
+ATOMIC_OP(or, |=)
+ATOMIC_OP(xor, ^=)
 
 #undef ATOMIC_OPS
 #undef ATOMIC_OP_RETURN
 #undef ATOMIC_OP
 
-static inline void atomic_clear_mask(unsigned int mask, atomic_t *v)
+static inline __deprecated void atomic_clear_mask(unsigned int mask, atomic_t *v)
 {
-	unsigned long flags;
-
-	__global_lock1(flags);
-	fence();
-	v->counter &= ~mask;
-	__global_unlock1(flags);
+	atomic_and(~mask, v);
 }
 
-static inline void atomic_set_mask(unsigned int mask, atomic_t *v)
+static inline __deprecated void atomic_set_mask(unsigned int mask, atomic_t *v)
 {
-	unsigned long flags;
-
-	__global_lock1(flags);
-	fence();
-	v->counter |= mask;
-	__global_unlock1(flags);
+	atomic_or(mask, v);
 }
 
 static inline int atomic_cmpxchg(atomic_t *v, int old, int new)

  parent reply	other threads:[~2015-07-16 17:21 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 17:21 [PATCH 00/28] arch: Provide atomic logic ops Peter Zijlstra
2015-07-16 17:21 ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 01/28] atomic: Prepare generic atomic implementation for " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 02/28] alpha: Provide atomic_{or,xor,and} Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 03/28] arc: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 04/28] arm: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 05/28] arm64: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 06/28] avr32: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 07/28] blackfin: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 08/28] hexagon: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 09/28] ia64: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 10/28] m32r: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 11/28] m68k: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` Peter Zijlstra [this message]
2015-07-16 17:21   ` [PATCH 12/28] metag: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 13/28] mips: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 14/28] mn10300: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 15/28] parisc: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 16/28] powerpc: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 17/28] sh: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 18/28] sparc: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 19/28] xtensa: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 20/28] s390: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 21/28] x86: " Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 22/28] frv: Rewrite atomic implementation Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 23/28] h8300: Provide atomic_{or,xor,and} Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 24/28] tile: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 25/28] atomic: " Peter Zijlstra
2015-07-16 17:21 ` [PATCH 26/28] atomic: Collapse all atomic_{set,clear}_mask definitions Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 27/28] atomic: Replace atomic_{set,clear}_mask() usage Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-16 17:21 ` [PATCH 28/28] atomic: Add simple atomic_t tests Peter Zijlstra
2015-07-16 17:21   ` Peter Zijlstra
2015-07-17 12:57 ` [PATCH 00/28] arch: Provide atomic logic ops Will Deacon
2015-07-17 12:57   ` Will Deacon
2015-07-21 21:13 ` rkuo
2015-07-27 11:01 ` Will Deacon
2015-07-27 11:01   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716172925.241515353@infradead.org \
    --to=peterz@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=cmetcalf@ezchip.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hskinnemoen@gmail.com \
    --cc=james.hogan@imgtec.com \
    --cc=jejb@parisc-linux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=realmz6@gmail.com \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=tony.luck@intel.com \
    --cc=vgupta@synopsys.com \
    --cc=will.deacon@arm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox