linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vineet.Gupta1@synopsys.com, arc-linux-dev@synopsys.com,
	arnd@arndb.de, Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode
Date: Wed, 19 Aug 2015 01:37:13 +0200	[thread overview]
Message-ID: <20150818233713.GP20948@worktop> (raw)
In-Reply-To: <1438787614-14074-7-git-send-email-abrodkin@synopsys.com>

On Wed, Aug 05, 2015 at 06:13:32PM +0300, Alexey Brodkin wrote:
> +	hwc->config = 0;
> +
> +	if (is_isa_arcv2()) {
> +		/* "exclude user" means "count only kernel" */
> +		if (event->attr.exclude_user)
> +			hwc->config |= ARC_REG_PCT_CONFIG_KERN;
> +
> +		/* "exclude kernel" means "count only user" */
> +		if (event->attr.exclude_kernel)
> +			hwc->config |= ARC_REG_PCT_CONFIG_USER;
> +	}
> +
>  	switch (event->attr.type) {
>  	case PERF_TYPE_HARDWARE:
>  		if (event->attr.config >= PERF_COUNT_HW_MAX)
>  			return -ENOENT;
>  		if (arc_pmu->ev_hw_idx[event->attr.config] < 0)
>  			return -ENOENT;
> -		hwc->config = arc_pmu->ev_hw_idx[event->attr.config];
> +		hwc->config |= arc_pmu->ev_hw_idx[event->attr.config];

So I would still very much like perf_event_attr::config to reflect the
value you'll program into hardware.

If you want to do that weird 4 character lookup thing, use a special
hardware event (possibly 0 if that is not a valid value), and stuff the
4 chars in ::config1

  parent reply	other threads:[~2015-08-18 23:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 15:13 [PATCH v2 0/8] ARCv2 port to Linux - (C) perf Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 1/8] ARC: perf: support RAW events Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 2/8] ARC: perf: cap the number of counters to hardware max of 32 Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 3/8] ARCv2: perf: implement "event_set_period" for future use with interrupts Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-18 17:52   ` Peter Zijlstra
2015-08-18 18:03     ` Alexey Brodkin
2015-08-20 10:46     ` Alexey Brodkin
2015-08-18 17:55   ` Peter Zijlstra
2015-08-20 11:25     ` Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 4/8] ARCv2: perf: Support sampling events using overflow interrupts Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-18 22:12   ` Peter Zijlstra
2015-08-20 11:30     ` Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 5/8] ARCv2: perf: set usable max period as a half of real max period Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 6/8] ARCv2: perf: implement exclusion of event counting in user or kernel mode Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-18 23:37   ` Peter Zijlstra [this message]
2015-08-20 11:33     ` Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 7/8] ARCv2: perf: SMP support Alexey Brodkin
2015-08-05 15:13 ` [PATCH v2 8/8] ARCv2: perf: Finally introduce HS perf unit Alexey Brodkin
2015-08-05 15:13   ` Alexey Brodkin
2015-08-10  8:29 ` [PATCH v2 0/8] ARCv2 port to Linux - (C) perf Alexey Brodkin
2015-08-10  8:29   ` Alexey Brodkin
2015-08-14  7:41 ` [arc-linux-dev] " Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818233713.GP20948@worktop \
    --to=peterz@infradead.org \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=acme@kernel.org \
    --cc=arc-linux-dev@synopsys.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).