From: Christoph Hellwig <hch@infradead.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: arnd@arndb.de, linux-arch@vger.kernel.org, mingo@kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux-s390@vger.kernel.org, bp@suse.de, linux@roeck-us.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rostedt@goodmis.org, "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit
Date: Sat, 29 Aug 2015 08:25:05 -0700 [thread overview]
Message-ID: <20150829152505.GA23449@infradead.org> (raw)
In-Reply-To: <1440807447-584-1-git-send-email-mcgrof@do-not-panic.com>
On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> The S390 architecture requires a custom pci_iomap() implementation
> as the asm-generic implementation assumes there are disjunctions
> between PCI BARs, and on S390 PCI BAR are not disjunctive, S390 requires
> the bar parameter in order to find the corresponding device and create
> the mapping cookie.
>
> This clash with the asm-generic pci_iomap() implementation is implicit,
> there are no current semantics to make this incompatability explicit.
> Make the S390 PCI BAR non-disjunction incompatibility explicit, and
> also pave the way for alternative incompatibilities to be defined.
>
> While at it, as with the ioremap*() variants, since we have no clear
> semantics yet well defined provide a solution for them that returns
> NULL. This allows architectures to move forward by defining pci_ioremap*()
> variants without requiring immediate changes to all architectures. Each
> architecture then can implement their own solution as needed and
> when they get to it.
Now that you have the config symbol available why not move the S390
implementation to generic code based on that can kill of
asm/pci_iomap.h? Seems like we're really not dealing with something
inherent to the architecture, but two possible implementations based
on architecture constraints.
next prev parent reply other threads:[~2015-08-29 15:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 0:17 [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit Luis R. Rodriguez
2015-08-29 2:13 ` Randy Dunlap
2015-10-02 23:17 ` Luis R. Rodriguez
2015-10-04 0:14 ` Randy Dunlap
2015-10-05 16:58 ` Luis R. Rodriguez
2015-08-29 15:25 ` Christoph Hellwig [this message]
2015-09-03 1:45 ` Luis R. Rodriguez
2015-08-30 19:30 ` Arnd Bergmann
2015-09-03 1:44 ` Luis R. Rodriguez
2015-09-03 1:47 ` Luis R. Rodriguez
2015-09-08 9:54 ` Luis R. Rodriguez
2015-09-08 13:42 ` Arnd Bergmann
2015-09-11 8:14 ` Martin Schwidefsky
2015-10-03 0:04 ` Luis R. Rodriguez
2015-10-03 0:04 ` Luis R. Rodriguez
2015-10-02 23:53 ` Luis R. Rodriguez
2015-10-04 19:02 ` Arnd Bergmann
2015-10-04 19:02 ` Arnd Bergmann
2015-10-05 17:09 ` Luis R. Rodriguez
2015-10-05 17:09 ` Luis R. Rodriguez
2015-10-06 11:15 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829152505.GA23449@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).