linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>,
	Matthew Wilcox <matthew.r.wilcox@intel.com>,
	Minchan Kim <minchan@kernel.org>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, arc-linux-dev@synopsys.com
Subject: Re: [PATCH 09/11] mm,thp: introduce flush_pmd_tlb_range
Date: Wed, 16 Sep 2015 15:26:28 -0700	[thread overview]
Message-ID: <20150916152628.32073b37c02550557672092c@linux-foundation.org> (raw)
In-Reply-To: <1440666194-21478-10-git-send-email-vgupta@synopsys.com>

On Thu, 27 Aug 2015 14:33:12 +0530 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:

> --- a/mm/pgtable-generic.c
> +++ b/mm/pgtable-generic.c
> @@ -84,6 +84,19 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address,
>  
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>  
> +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE
> +
> +/*
> + * ARCHes with special requirements for evicting THP backing TLB entries can
> + * implement this. Otherwise also, it can help optimizing thp flush operation.
> + * flush_tlb_range() can have optimization to nuke the entire TLB if flush span
> + * is greater than a threashhold, which will likely be true for a single
> + * huge page.
> + * e.g. see arch/arc: flush_pmd_tlb_range
> + */
> +#define flush_pmd_tlb_range(vma, addr, end)	flush_tlb_range(vma, addr, end)
> +#endif

Did you consider using a __weak function here?

  reply	other threads:[~2015-09-16 22:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  9:03 [PATCH 00/11] THP support for ARC Vineet Gupta
2015-08-27  9:03 ` [PATCH 01/11] ARC: mm: pte flags comsetic cleanups, comments Vineet Gupta
2015-08-27  9:03 ` [PATCH 02/11] ARC: mm: Introduce PTE_SPECIAL Vineet Gupta
2015-08-27  9:03 ` [PATCH 03/11] Documentation/features/vm: pte_special now supported by ARC Vineet Gupta
2015-08-27  9:03 ` [PATCH 04/11] ARCv2: mm: THP support Vineet Gupta
2015-08-27 15:32   ` Kirill A. Shutemov
2015-08-27 15:32     ` Kirill A. Shutemov
2015-08-27 16:56     ` Vineet Gupta
2015-08-27 16:56       ` Vineet Gupta
2015-08-28  6:09     ` Vineet Gupta
2015-08-27  9:03 ` [PATCH 05/11] ARCv2: mm: THP: boot validation/reporting Vineet Gupta
2015-08-27  9:03 ` [PATCH 06/11] Documentation/features/vm: THP now supported by ARC Vineet Gupta
2015-08-27  9:03 ` [PATCH 07/11] mm: move some code around Vineet Gupta
2015-08-27  9:03 ` [PATCH 08/11] mm,thp: reduce ifdef'ery for THP in generic code Vineet Gupta
2015-09-16 22:25   ` Andrew Morton
2015-09-16 22:25     ` Andrew Morton
2015-09-16 23:45     ` Vineet Gupta
2015-08-27  9:03 ` [PATCH 09/11] mm,thp: introduce flush_pmd_tlb_range Vineet Gupta
2015-09-16 22:26   ` Andrew Morton [this message]
2015-09-16 23:57     ` Vineet Gupta
2015-08-27  9:03 ` [PATCH 10/11] ARCv2: mm: THP: Implement flush_pmd_tlb_range() optimization Vineet Gupta
2015-08-27  9:03 ` [PATCH 11/11] ARCv2: Add a DT which enables THP Vineet Gupta
2015-09-03  8:46 ` [PATCH 00/11] THP support for ARC Vineet Gupta
2015-09-16 22:27 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916152628.32073b37c02550557672092c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=arc-linux-dev@synopsys.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).