From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Date: Thu, 19 Nov 2015 16:18:43 +0000 Message-ID: <20151119161843.GA8644@n2100.arm.linux.org.uk> References: <5663971.11WtULN11Y@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5663971.11WtULN11Y@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: "jonas@southpole.se" , "linux-arch@vger.kernel.org" , "vgupta@synopsys.com" , "abrodkin@synopsys.com" , kernel mailing list , "dhowells@redhat.com" , "linux-m68k@lists.linux-m68k.org" , "geert@linux-m68k.org" , linux-arm-kernel@lists.infradead.org, "gerg@uclinux.org" , Andrew Morton , "linux-snps-arc@lists.infradead.org" , Chen Gang List-Id: linux-arch.vger.kernel.org On Thu, Nov 19, 2015 at 12:25:45PM +0100, Arnd Bergmann wrote: > On Thursday 19 November 2015 03:40:25 Chen Gang wrote: > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h > > index 37d1fe2..67cfb7d 100644 > > --- a/include/asm-generic/page.h > > +++ b/include/asm-generic/page.h > > @@ -24,9 +24,6 @@ > > > > #ifndef __ASSEMBLY__ > > > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > > -#define free_user_page(page, addr) free_page(addr) > > - > > #define clear_page(page) memset((page), 0, PAGE_SIZE) > > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > > > > > Looks good. I can take the asm-generic portion when you split it up, and > I can also help you merge the remaining patches in case some of > the arch maintainers fail to pick them up. I think all five of them > are actively maintained though, so the patches should just go through > the respective architecture trees. Or we just ack the patch and have it go through one tree, which I think is the most sensible. I can't imagine that there would be any major conflicts here, surely no one is constantly changing their asm/page.h ? -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40502 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889AbbKSQTW (ORCPT ); Thu, 19 Nov 2015 11:19:22 -0500 Date: Thu, 19 Nov 2015 16:18:43 +0000 From: Russell King - ARM Linux Subject: Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Message-ID: <20151119161843.GA8644@n2100.arm.linux.org.uk> References: <5663971.11WtULN11Y@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5663971.11WtULN11Y@wuerfel> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, "linux-snps-arc@lists.infradead.org" , Chen Gang , "vgupta@synopsys.com" , "dhowells@redhat.com" , "geert@linux-m68k.org" , "gerg@uclinux.org" , "jonas@southpole.se" , "abrodkin@synopsys.com" , Andrew Morton , "linux-arch@vger.kernel.org" , kernel mailing list , "linux-m68k@lists.linux-m68k.org" Message-ID: <20151119161843.zn1baTVC858GPPf0B7hyySrAKKGDx4vAepYM8kT47b8@z> On Thu, Nov 19, 2015 at 12:25:45PM +0100, Arnd Bergmann wrote: > On Thursday 19 November 2015 03:40:25 Chen Gang wrote: > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h > > index 37d1fe2..67cfb7d 100644 > > --- a/include/asm-generic/page.h > > +++ b/include/asm-generic/page.h > > @@ -24,9 +24,6 @@ > > > > #ifndef __ASSEMBLY__ > > > > -#define get_user_page(vaddr) __get_free_page(GFP_KERNEL) > > -#define free_user_page(page, addr) free_page(addr) > > - > > #define clear_page(page) memset((page), 0, PAGE_SIZE) > > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > > > > > Looks good. I can take the asm-generic portion when you split it up, and > I can also help you merge the remaining patches in case some of > the arch maintainers fail to pick them up. I think all five of them > are actively maintained though, so the patches should just go through > the respective architecture trees. Or we just ack the patch and have it go through one tree, which I think is the most sensible. I can't imagine that there would be any major conflicts here, surely no one is constantly changing their asm/page.h ? -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.