Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"

Russell King - ARM Linux
2015-11-23T16:37:56Z

On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote:
> I think you could do better by simply calling panic("BUG!") instead as
> BUG() does. It will avoid the printk() call and pushing the file/line
> number onto the stack. It will also probably not inflate the rodata this
> way.

Does that not depend on the architectures BUG() implementation? If an
architecture implements it as a signalling illegal instruction and a
lookup table, changing it to be a panic() would probably be more code.

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.