Re: [PATCH 1/2] arch: consolidate CONFIG_STRICT_DEVM in lib/Kconfig.debug

Heiko Carstens
2015-11-23T09:53:12Z

On Sat, Nov 21, 2015 at 07:57:02PM -0800, Dan Williams wrote:
> Let all the archs that implement CONFIG_STRICT_DEVM use a common
> definition in lib/Kconfig.debug.
>
> Note, the 'depends on !SPARC' is due to sparc not implementing
> devmem_is_allowed().
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> arch/arm/Kconfig.debug | 14 --------------
> arch/arm64/Kconfig.debug | 14 --------------
> arch/powerpc/Kconfig.debug | 12 ------------
> arch/s390/Kconfig.debug | 12 ------------
> arch/tile/Kconfig | 3 ---
> arch/unicore32/Kconfig.debug | 14 --------------
> arch/x86/Kconfig.debug | 17 -----------------
> lib/Kconfig.debug | 19 +++++++++++++++++++
> 8 files changed, 19 insertions(+), 86 deletions(-)

For s390

Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8c15b29d5adc..ad85145d0047 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1853,3 +1853,22 @@ source "samples/Kconfig"
>
> source "lib/Kconfig.kgdb"
>
> +config STRICT_DEVMEM
> + bool "Filter access to /dev/mem"
> + depends on MMU
> + depends on !SPARC
> + default y if TILE || PPC || S390

I wouldn't mind if you would remove s390 from this list.