linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	PaX Team <pageexec@freemail.hu>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Mathias Krause <minipli@googlemail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, x86-ml <x86@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-arch <linux-arch@vger.kernel.org>,
	Emese Revfy <re.emese@gmail.com>
Subject: Re: [kernel-hardening] [PATCH 0/2] introduce post-init read-only memory
Date: Sun, 29 Nov 2015 09:05:05 +0100	[thread overview]
Message-ID: <20151129080505.GA23721@gmail.com> (raw)
In-Reply-To: <CALCETrVVYMUgxABoEVfJgLtE+nB44aijqG5saq8dTQSTVWxbMA@mail.gmail.com>


* Andy Lutomirski <luto@amacapital.net> wrote:

> >>  - print a warning and a backtrace, and just mark the page read-write
> >> so that the machine survives, but we get notified and can fix whatever
> >> broken code
> >
> > This seems very easy to add. Should I basically reverse the effects of 
> > mark_rodata_ro(), or should I only make the new ro-after-init section as RW? 
> > (I think the former would be easier.)
> 
> I'd suggest verifying that the page in question is .data..ro_after_init and, if 
> so, marking that one page RW.

Yes, this was PaX's suggestion as well, and I agree: doing that turns a quite 
possibly unrecoverable boot/shutdown time or suspend/resume time (suspend is 
really a special category of 'bootup') crasher oops into a more informative stack 
dump.

These ro related faults tend to trigger when init/deinit is running, and oopsing 
in those sequences is typically a lot less survivable than say oopsing in a high 
level system call while not holding locks.

Thanks,

	Ingo

  reply	other threads:[~2015-11-29  8:05 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 21:38 [PATCH 0/2] introduce post-init read-only memory Kees Cook
2015-11-24 21:38 ` Kees Cook
2015-11-24 21:38 ` [PATCH 1/2] x86: " Kees Cook
2015-11-24 21:38   ` Kees Cook
2015-11-25  0:34   ` Andy Lutomirski
2015-11-25  0:34     ` Andy Lutomirski
2015-11-25  0:44     ` Kees Cook
2015-11-25  0:54       ` [kernel-hardening] " Michael Ellerman
2015-11-25 15:03         ` Kees Cook
2015-11-25 23:05           ` Michael Ellerman
2015-11-25 23:32             ` Kees Cook
2015-11-25 23:32               ` [kernel-hardening] " Kees Cook
2015-11-24 21:38 ` [PATCH 2/2] x86, vdso: mark vDSO read-only after init Kees Cook
2015-11-24 21:38   ` Kees Cook
2015-11-25  9:13 ` [PATCH 0/2] introduce post-init read-only memory Mathias Krause
2015-11-25  9:13   ` [kernel-hardening] " Mathias Krause
2015-11-25 10:06   ` Clemens Ladisch
2015-11-25 10:06     ` Clemens Ladisch
2015-11-25 11:14     ` PaX Team
2015-11-25 11:14       ` [kernel-hardening] " PaX Team
2015-11-25 11:05   ` PaX Team
2015-11-25 11:05     ` [kernel-hardening] " PaX Team
2015-11-26  8:54     ` Ingo Molnar
2015-11-26  9:57       ` PaX Team
2015-11-26  9:57         ` [kernel-hardening] " PaX Team
2015-11-26 10:42         ` Ingo Molnar
2015-11-26 12:14           ` PaX Team
2015-11-26 12:14             ` [kernel-hardening] " PaX Team
2015-11-27  8:05             ` Ingo Molnar
2015-11-27  8:05               ` [kernel-hardening] " Ingo Molnar
2015-11-27 15:29               ` PaX Team
2015-11-27 15:29                 ` [kernel-hardening] " PaX Team
2015-11-27 16:30                 ` Andy Lutomirski
2015-11-29  8:08                 ` Ingo Molnar
2015-11-29  8:08                   ` Ingo Molnar
2015-11-29 11:15                   ` PaX Team
2015-11-29 11:15                     ` [kernel-hardening] " PaX Team
2015-11-29 15:39                     ` Ingo Molnar
2015-11-29 18:05                       ` Mathias Krause
2015-11-29 18:05                         ` [kernel-hardening] " Mathias Krause
2015-11-30  8:01                         ` Ingo Molnar
2015-11-30  8:01                           ` [kernel-hardening] " Ingo Molnar
2015-11-26 16:11       ` Andy Lutomirski
2015-11-26 16:11         ` [kernel-hardening] " Andy Lutomirski
2015-11-27  7:59         ` Ingo Molnar
2015-11-27  7:59           ` [kernel-hardening] " Ingo Molnar
2015-11-27 18:00           ` Linus Torvalds
2015-11-27 18:03             ` Linus Torvalds
2015-11-27 18:03               ` [kernel-hardening] " Linus Torvalds
2015-11-27 20:03             ` Kees Cook
2015-11-27 20:03               ` [kernel-hardening] " Kees Cook
2015-11-27 20:09               ` Andy Lutomirski
2015-11-29  8:05                 ` Ingo Molnar [this message]
2015-11-29  8:05                   ` Ingo Molnar
2015-11-30 21:14                   ` H. Peter Anvin
2015-11-30 21:14                     ` [kernel-hardening] " H. Peter Anvin
2015-11-30 21:33                     ` Kees Cook
2015-11-30 21:38                       ` Andy Lutomirski
2015-11-30 21:38                         ` Andy Lutomirski
2015-11-30 21:43                       ` H. Peter Anvin
2015-11-30 21:43                         ` [kernel-hardening] " H. Peter Anvin
2015-11-25 17:26   ` Kees Cook
2015-11-25 17:26     ` [kernel-hardening] " Kees Cook
2015-11-25 17:31   ` H. Peter Anvin
2015-11-25 17:31     ` [kernel-hardening] " H. Peter Anvin
2015-11-25 18:54     ` Kees Cook
2015-11-25 19:06       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151129080505.GA23721@gmail.com \
    --to=mingo@kernel.org \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=mpe@ellerman.id.au \
    --cc=pageexec@freemail.hu \
    --cc=re.emese@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).