From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search Date: Mon, 4 Jan 2016 13:26:20 +0100 Message-ID: <20160104122619.GH22941@pd.tnic> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> <567F315B.8080005@hpe.com> <20151227021257.GA13560@dhcp-128-25.nay.redhat.com> <20151227102406.GB19398@nazgul.tnic> <20160104092937.GB7033@dhcp-128-65.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160104092937.GB7033-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dave Young Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Toshi Kani , Minfei Huang , linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, Dan Williams List-Id: linux-arch.vger.kernel.org On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > Replied to Toshi old kernel will export the "GART" region for amd cards. > So for old kernel and new kexec-tools we will have problem. > > I think add the GART desc for compitibility purpose is doable, no? Just read your other mails too. If I see it correctly, there's only one place which has "GART": $ git grep -e \"GART\" arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0, -1, So crash.c only excludes this region but the kernel doesn't create it. Right? So we can kill that walk_iomem_res(), as you say. Which would be even nicer... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([78.46.96.112]:55229 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbcADM0k (ORCPT ); Mon, 4 Jan 2016 07:26:40 -0500 Date: Mon, 4 Jan 2016 13:26:20 +0100 From: Borislav Petkov Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search Message-ID: <20160104122619.GH22941@pd.tnic> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> <20151226103804.GB21988@pd.tnic> <567F315B.8080005@hpe.com> <20151227021257.GA13560@dhcp-128-25.nay.redhat.com> <20151227102406.GB19398@nazgul.tnic> <20160104092937.GB7033@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160104092937.GB7033@dhcp-128-65.nay.redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Young Cc: Minfei Huang , Toshi Kani , linux-arch@vger.kernel.org, linux-nvdimm@ml01.01.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Dan Williams Message-ID: <20160104122620.mqCcT2Cmx0sGUfPrp9AJyasYdK__8GwbAAQOUT54mEo@z> On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote: > Replied to Toshi old kernel will export the "GART" region for amd cards. > So for old kernel and new kexec-tools we will have problem. > > I think add the GART desc for compitibility purpose is doable, no? Just read your other mails too. If I see it correctly, there's only one place which has "GART": $ git grep -e \"GART\" arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0, -1, So crash.c only excludes this region but the kernel doesn't create it. Right? So we can kill that walk_iomem_res(), as you say. Which would be even nicer... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.