From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 14/16] input: Redefine INPUT_COMPAT_TEST as in_compat_syscall() Date: Wed, 27 Jan 2016 13:06:10 -0800 Message-ID: <20160127210610.GB28687@dtor-ws> References: <64480084bc652d5fa91bf5cd4be979e2f1e4cf11.1453759363.git.luto@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f170.google.com ([209.85.192.170]:34044 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966209AbcA0VGR (ORCPT ); Wed, 27 Jan 2016 16:06:17 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Lutomirski Cc: Andy Lutomirski , Andrew Morton , Al Viro , Linus Torvalds , X86 ML , linux-arch , David Miller , "linux-s390@vger.kernel.org" , Chris Metcalf , linux-parisc@vger.kernel.org, "linux-mips@linux-mips.org" , sparclinux@vger.kernel.org On Wed, Jan 27, 2016 at 12:29:14PM -0800, Andy Lutomirski wrote: > On Wed, Jan 27, 2016 at 11:17 AM, Dmitry Torokhov > wrote: > > Hi Andy, > > > > On Mon, Jan 25, 2016 at 2:24 PM, Andy Lutomirski wrote: > >> The input compat code should work like all other compat code: for > >> 32-bit syscalls, use the 32-bit ABI and for 64-bit syscalls, use the > >> 64-bit ABI. We have a helper for that (in_compat_syscall()): just > >> use it. > >> > >> Signed-off-by: Andy Lutomirski > >> --- > >> drivers/input/input-compat.h | 12 +----------- > >> 1 file changed, 1 insertion(+), 11 deletions(-) > >> > >> diff --git a/drivers/input/input-compat.h b/drivers/input/input-compat.h > >> index 148f66fe3205..0f25878d5fa2 100644 > >> --- a/drivers/input/input-compat.h > >> +++ b/drivers/input/input-compat.h > >> @@ -17,17 +17,7 @@ > >> > >> #ifdef CONFIG_COMPAT > >> > >> -/* Note to the author of this code: did it ever occur to > >> - you why the ifdefs are needed? Think about it again. -AK */ > >> -#if defined(CONFIG_X86_64) || defined(CONFIG_TILE) > >> -# define INPUT_COMPAT_TEST is_compat_task() > >> -#elif defined(CONFIG_S390) > >> -# define INPUT_COMPAT_TEST test_thread_flag(TIF_31BIT) > >> -#elif defined(CONFIG_MIPS) > >> -# define INPUT_COMPAT_TEST test_thread_flag(TIF_32BIT_ADDR) > >> -#else > >> -# define INPUT_COMPAT_TEST test_thread_flag(TIF_32BIT) > >> -#endif > >> +#define INPUT_COMPAT_TEST in_compat_syscall() > >> > > > > > > If we now have function that works on all arches I'd prefer if we used > > it directly instead of continuing using INPUT_COMPAT_TEST. > > I'll write a followup patch for that if you don't beat me to it. I promise I wont ;) -- Dmitry