From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [PATCH v4 3/8] param: convert some "on"/"off" users to strtobool Date: Wed, 27 Jan 2016 14:11:05 -0700 Message-ID: <20160127211105.GA41450@davidb.org> References: <1453226922-16831-1-git-send-email-keescook@chromium.org> <1453226922-16831-4-git-send-email-keescook@chromium.org> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <1453226922-16831-4-git-send-email-keescook@chromium.org> To: kernel-hardening@lists.openwall.com Cc: Ingo Molnar , Kees Cook , Andy Lutomirski , "H. Peter Anvin" , Michael Ellerman , Mathias Krause , Thomas Gleixner , x86@kernel.org, Arnd Bergmann , PaX Team , Emese Revfy , linux-kernel@vger.kernel.org, linux-arch List-Id: linux-arch.vger.kernel.org On Tue, Jan 19, 2016 at 10:08:37AM -0800, Kees Cook wrote: >diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c >index 9cc20af58c76..f5ea98490ffa 100644 >--- a/kernel/time/tick-sched.c >+++ b/kernel/time/tick-sched.c >@@ -387,20 +388,14 @@ void __init tick_nohz_init(void) > /* > * NO HZ enabled ? > */ >-static int tick_nohz_enabled __read_mostly = 1; >+static bool tick_nohz_enabled __read_mostly = true; > unsigned long tick_nohz_active __read_mostly; > /* > * Enable / Disable tickless mode > */ Just discovered this conflicts with a recent patch with CONFIG_NO_HZ_COMMON: commit 46373a15f65fe862f31c19a484acdf551f2b442f Author: Jean Delvare Date: Mon Jan 11 17:40:31 2016 +0100 time: nohz: Expose tick_nohz_enabled kernel/time/tick-sched.c:390:6: error: conflicting types for ‘tick_nohz_enabled’ bool tick_nohz_enabled __read_mostly = true; ^ In file included from kernel/time/tick-internal.h:5:0, from kernel/time/tick-sched.c:30: include/linux/tick.h:101:12: note: previous declaration of ‘tick_nohz_enabled’ was here extern int tick_nohz_enabled; ^ Fixing the compilation error, it compiles and boots on arm64, however it isn't detecting the write (with the lkdtm test). I'll continue looking into what's preventing this. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:36230 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968249AbcA0VKu (ORCPT ); Wed, 27 Jan 2016 16:10:50 -0500 Received: by mail-oi0-f50.google.com with SMTP id o124so13990108oia.3 for ; Wed, 27 Jan 2016 13:10:50 -0800 (PST) Date: Wed, 27 Jan 2016 14:11:05 -0700 From: David Brown Subject: Re: [kernel-hardening] [PATCH v4 3/8] param: convert some "on"/"off" users to strtobool Message-ID: <20160127211105.GA41450@davidb.org> References: <1453226922-16831-1-git-send-email-keescook@chromium.org> <1453226922-16831-4-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453226922-16831-4-git-send-email-keescook@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: kernel-hardening@lists.openwall.com Cc: Ingo Molnar , Kees Cook , Andy Lutomirski , "H. Peter Anvin" , Michael Ellerman , Mathias Krause , Thomas Gleixner , x86@kernel.org, Arnd Bergmann , PaX Team , Emese Revfy , linux-kernel@vger.kernel.org, linux-arch Message-ID: <20160127211105.4c3GHxqZXOnyEE3XzPzp8DjA6z4pHjFYEOiFJ4JlU1s@z> On Tue, Jan 19, 2016 at 10:08:37AM -0800, Kees Cook wrote: >diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c >index 9cc20af58c76..f5ea98490ffa 100644 >--- a/kernel/time/tick-sched.c >+++ b/kernel/time/tick-sched.c >@@ -387,20 +388,14 @@ void __init tick_nohz_init(void) > /* > * NO HZ enabled ? > */ >-static int tick_nohz_enabled __read_mostly = 1; >+static bool tick_nohz_enabled __read_mostly = true; > unsigned long tick_nohz_active __read_mostly; > /* > * Enable / Disable tickless mode > */ Just discovered this conflicts with a recent patch with CONFIG_NO_HZ_COMMON: commit 46373a15f65fe862f31c19a484acdf551f2b442f Author: Jean Delvare Date: Mon Jan 11 17:40:31 2016 +0100 time: nohz: Expose tick_nohz_enabled kernel/time/tick-sched.c:390:6: error: conflicting types for ‘tick_nohz_enabled’ bool tick_nohz_enabled __read_mostly = true; ^ In file included from kernel/time/tick-internal.h:5:0, from kernel/time/tick-sched.c:30: include/linux/tick.h:101:12: note: previous declaration of ‘tick_nohz_enabled’ was here extern int tick_nohz_enabled; ^ Fixing the compilation error, it compiles and boots on arm64, however it isn't detecting the write (with the lkdtm test). I'll continue looking into what's preventing this. David