From: Al Viro <viro@ZenIV.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/12] m68k: move exports to definitions
Date: Mon, 1 Feb 2016 14:53:55 +0000 [thread overview]
Message-ID: <20160201145355.GK17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAMuHMdUUecCdGcK5FxL6e2FeD6-gyoWkbC_+RZzzb_mzHrcGyg@mail.gmail.com>
On Mon, Feb 01, 2016 at 02:30:16PM +0100, Geert Uytterhoeven wrote:
> The kernel has all the *di3 variants:
>
> 002eae2c T __ashldi3
> 002eae70 T __ashrdi3
> 002eaebc T __lshrdi3
> 002eaf00 T __muldi3
> 0038a6d0 R __ksymtab___ashldi3
> 0038a6d8 R __ksymtab___ashrdi3
> 0038ab68 R __ksymtab___lshrdi3
> 0038ab90 R __ksymtab___muldi3
> 003a8a5a r __kstrtab___ashldi3
> 003a8a64 r __kstrtab___ashrdi3
> 003a8a6e r __kstrtab___lshrdi3
> 003a8a78 r __kstrtab___muldi3
>
> Hence the *si3 are missing:
>
> __divsi3
> __modsi3
> __mulsi3
> __udivsi3
> __umodsi3
Does your .config have CPU_HAS_NO_MULDIV64? Because otherwise these objects
won't be built and their exports had been conditional on that as well:
#if defined(CONFIG_CPU_HAS_NO_MULDIV64)
/*
* Simpler 68k and ColdFire parts also need a few other gcc functions.
*/
extern long long __divsi3(long long, long long);
extern long long __modsi3(long long, long long);
extern long long __mulsi3(long long, long long);
extern long long __udivsi3(long long, long long);
extern long long __umodsi3(long long, long long);
EXPORT_SYMBOL(__divsi3);
EXPORT_SYMBOL(__modsi3);
EXPORT_SYMBOL(__mulsi3);
EXPORT_SYMBOL(__udivsi3);
EXPORT_SYMBOL(__umodsi3);
#endif
is what we have in mainline m68k_ksyms.c. Neither allmodconfig, nor any of
defconfigs have it. And on a coldfire build they are built and exported as
expected:
$ grep si3 ../build/coldfire/System.map
002be860 T __divsi3
002be890 T __modsi3
002be8b8 T __mulsi3
002be8dc T __udivsi3
002be90c T __umodsi3
003ed960 R __ksymtab___divsi3
003edc80 R __ksymtab___modsi3
003edca8 R __ksymtab___mulsi3
003edff8 R __ksymtab___udivsi3
003ee000 R __ksymtab___umodsi3
003f7ba4 r __kcrctab___divsi3
003f7d34 r __kcrctab___modsi3
003f7d48 r __kcrctab___mulsi3
003f7ef0 r __kcrctab___udivsi3
003f7ef4 r __kcrctab___umodsi3
004144fe r __kstrtab___divsi3
00414507 r __kstrtab___modsi3
00414510 r __kstrtab___mulsi3
00414519 r __kstrtab___udivsi3
00414523 r __kstrtab___umodsi3
next prev parent reply other threads:[~2016-02-01 14:53 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 19:17 [RFC][PATCHSET] allowing exports in *.S Al Viro
2016-01-29 19:17 ` Al Viro
2016-01-29 19:18 ` [PATCH 01/12] [kbuild] handle exports in lib-y objects reliably Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-29 19:18 ` [PATCH 02/12] EXPORT_SYMBOL() for asm Al Viro
2016-01-29 21:06 ` Arnd Bergmann
2016-01-29 21:06 ` Arnd Bergmann
2016-01-29 19:18 ` [PATCH 03/12] x86: move exports to actual definitions Al Viro
2016-01-29 19:18 ` Al Viro
2016-02-01 8:12 ` Thomas Gleixner
2016-02-01 8:12 ` Thomas Gleixner
2016-01-29 19:18 ` [PATCH 04/12] alpha: " Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-29 19:18 ` [PATCH 05/12] m68k: move exports to definitions Al Viro
2016-01-29 19:18 ` Al Viro
2016-02-01 10:52 ` Geert Uytterhoeven
2016-02-01 10:52 ` Geert Uytterhoeven
2016-02-01 12:18 ` Al Viro
2016-02-01 12:18 ` Al Viro
2016-02-01 13:30 ` Geert Uytterhoeven
2016-02-01 13:30 ` Geert Uytterhoeven
2016-02-01 14:53 ` Al Viro [this message]
2016-02-01 14:53 ` Al Viro
2016-02-01 15:32 ` Geert Uytterhoeven
2016-02-01 15:32 ` Geert Uytterhoeven
2016-01-29 19:18 ` [PATCH 06/12] s390: " Al Viro
2016-01-29 19:18 ` Al Viro
2016-02-02 11:29 ` Heiko Carstens
2016-02-02 11:29 ` Heiko Carstens
2016-01-29 19:18 ` [PATCH 07/12] arm: " Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-29 19:18 ` [PATCH 08/12] ppc: " Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-29 19:18 ` [PATCH 09/12] sparc: " Al Viro
2016-01-30 7:08 ` David Miller
2016-01-30 7:08 ` David Miller
2016-01-29 19:18 ` [PATCH 10/12] ia64: " Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-29 19:18 ` [PATCH 11/12] [sparc] unify 32bit and 64bit string.h Al Viro
2016-01-29 19:18 ` Al Viro
2016-01-30 7:08 ` David Miller
2016-01-30 7:08 ` David Miller
2016-01-29 19:18 ` [PATCH 12/12] sparc32: debride memcpy.S a bit Al Viro
2016-01-30 7:07 ` David Miller
2016-01-30 7:07 ` David Miller
2016-02-01 15:12 ` [PATCH 02/12] EXPORT_SYMBOL() for asm David Howells
2016-02-01 15:12 ` David Howells
2016-02-03 21:19 ` [RFC][PATCHSET v2] allowing exports in *.S Al Viro
2016-02-03 21:20 ` [PATCH v2 01/13] [kbuild] handle exports in lib-y objects reliably Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-04 22:33 ` Michal Marek
2016-02-04 22:33 ` Michal Marek
2016-02-05 0:18 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 02/13] EXPORT_SYMBOL() for asm Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-04 18:06 ` Al Viro
2016-02-04 18:06 ` Al Viro
2016-02-10 22:15 ` Nicolas Pitre
2016-02-03 21:20 ` [PATCH v2 03/13] x86: move exports to actual definitions Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 04/13] alpha: " Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 05/13] m68k: move exports to definitions Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 06/13] s390: " Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 07/13] arm: " Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-10 21:56 ` Nicolas Pitre
2016-02-03 21:20 ` [PATCH v2 08/13] ppc: " Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 09/13] ppc: get rid of unreachable abs() implementation Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 10/13] sparc: move exports to definitions Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 11/13] [sparc] unify 32bit and 64bit string.h Al Viro
2016-02-03 21:20 ` Al Viro
2016-02-03 21:20 ` [PATCH v2 12/13] sparc32: debride memcpy.S a bit Al Viro
2016-02-03 21:20 ` [PATCH v2 13/13] ia64: move exports to definitions Al Viro
2016-02-03 21:20 ` Al Viro
2016-08-02 14:01 ` [RFC][PATCHSET v2] allowing exports in *.S Michal Marek
2016-08-02 14:01 ` Michal Marek
2016-08-16 5:48 ` Michal Marek
2016-08-16 5:48 ` Michal Marek
2016-08-16 5:57 ` Michal Marek
2016-08-16 5:57 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201145355.GK17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).