From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH 03/19] x86/efi: get rid of superfluous __GFP_REPEAT Date: Tue, 12 Apr 2016 16:53:47 +0100 Message-ID: <20160412155347.GF2829@codeblueprint.co.uk> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-4-git-send-email-mhocko@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460372892-8157-4-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , LKML , Michal Hocko , linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon, 11 Apr, at 01:07:56PM, Michal Hocko wrote: > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > efi_alloc_page_tables uses __GFP_REPEAT but it allocates an order-0 > page. This means that this flag has never been actually useful here > because it has always been used only for PAGE_ALLOC_COSTLY requests. > > Cc: Matt Fleming > Cc: linux-arch@vger.kernel.org > Signed-off-by: Michal Hocko > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine. I suspect I copied it from other pgtable creation code, Reviewed-by: Matt Fleming -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:38853 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965911AbcDLPxw (ORCPT ); Tue, 12 Apr 2016 11:53:52 -0400 Received: by mail-wm0-f42.google.com with SMTP id u206so34109891wme.1 for ; Tue, 12 Apr 2016 08:53:51 -0700 (PDT) Date: Tue, 12 Apr 2016 16:53:47 +0100 From: Matt Fleming Subject: Re: [PATCH 03/19] x86/efi: get rid of superfluous __GFP_REPEAT Message-ID: <20160412155347.GF2829@codeblueprint.co.uk> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-4-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460372892-8157-4-git-send-email-mhocko@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , LKML , Michal Hocko , linux-arch@vger.kernel.org Message-ID: <20160412155347.PaC66aJ1JUHq5T6qoJWgnVrAU5N394Q5hx5CQRYIf54@z> On Mon, 11 Apr, at 01:07:56PM, Michal Hocko wrote: > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > efi_alloc_page_tables uses __GFP_REPEAT but it allocates an order-0 > page. This means that this flag has never been actually useful here > because it has always been used only for PAGE_ALLOC_COSTLY requests. > > Cc: Matt Fleming > Cc: linux-arch@vger.kernel.org > Signed-off-by: Michal Hocko > --- > arch/x86/platform/efi/efi_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine. I suspect I copied it from other pgtable creation code, Reviewed-by: Matt Fleming