From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH 24/25] arm64:ilp32: add vdso-ilp32 and use for signal return Date: Fri, 29 Apr 2016 17:01:55 +0100 Message-ID: <20160429160154.GC30316@e104818-lin.cambridge.arm.com> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-25-git-send-email-ynorov@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from foss.arm.com ([217.140.101.70]:52078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753317AbcD2QCC (ORCPT ); Fri, 29 Apr 2016 12:02:02 -0400 Content-Disposition: inline In-Reply-To: <1459894127-17698-25-git-send-email-ynorov@caviumnetworks.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yury Norov Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, Philipp Tomsich , joseph@codesourcery.com, christoph.muellner@theobroma-systems.com On Wed, Apr 06, 2016 at 01:08:46AM +0300, Yury Norov wrote: > ILP32 VDSO exports next symbols: > __kernel_rt_sigreturn; > __kernel_gettimeofday; > __kernel_clock_gettime; > __kernel_clock_getres; [...] > +$(obj)/gettimeofday-ilp32.o: $(src)/../vdso/gettimeofday.S > + $(call if_changed_dep,vdso-ilp32as) Are struct timeval and timespec the same between ILP32 and LP64? For example, __kernel_gettimeofday() assumes TVAL_TV_SEC offset defined in asm-offsets.c based on the LP64 timeval. > +$(obj)/sigreturn-ilp32.o: $(src)/../vdso/sigreturn.S > + $(call if_changed_dep,vdso-ilp32as) This one should be fine because ILP32 uses the same generic __NR_rt_sigreturn syscall number. -- Catalin